Skip to content

update queue status log message - #1403

Open
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:fix/update-queueStatus-log
Open

update queue status log message#1403
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:fix/update-queueStatus-log

Conversation

@JonathanMH

@JonathanMH JonathanMH commented Aug 19, 2026

Copy link
Copy Markdown

Description

When receiving queue log-messages via node-serial the output for the .value would be [object Object]

Changes Made

  • updated the log message to make use of the different relevant keys in the value object

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Summary by CodeRabbit

  • Bug Fixes
    • Improved queue-status logging to include the status result and available versus maximum queue entries.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

@JonathanMH is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 49e8ab8a-88bd-4b5c-92c9-a6392f33ac39

📥 Commits

Reviewing files that changed from the base of the PR and between 1db40fe and 05d73c0.

📒 Files selected for processing (1)
  • packages/sdk/src/core/packet-codec/decodePacket.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The queue-status trace log now reports the status result and current free entries against the maximum queue capacity.

Changes

Queue Status Logging

Layer / File(s) Summary
Update queue-status trace output
packages/sdk/src/core/packet-codec/decodePacket.ts
The trace log now reports the status result, free entries, and maximum entries instead of the raw queue-status value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 05d73

This is a localized queue status log-message update with no actionable merge-blocking risk remaining beyond normal checks and review.

Poem

I’m a rabbit with logs in my den,
Queue counts now tell more than then.
Free and max entries hop into sight,
Status results make the trace precise and bright.
Squeak! The packet path reads right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the queue status log message update.
Description check ✅ Passed The description explains the [object Object] problem and the logging change, but it does not include a Testing Done section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant