Skip to content

fix(settings): allow negative coordinates in position config #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzienisz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(settings): allow negative coordinates in position config #1381

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce35dc3
fix(settings): allow negative coordinates and enforce 7 decimal preci…
Aug 3, 2026
ff5e127
test(position): add validation tests for coordinates
Aug 3, 2026
d1f81fc
Merge branch 'main' into fix/negative-position-coordinates
Hunter275 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions apps/web/src/components/Form/FormInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,20 @@ export function GenericInput<T extends FieldValues>({
field.inputChange(e);
}

if (field.type !== "number") {
controllerField.onChange(newValue);
return;
}

// Preserve intermediate values while typing negative numbers or decimals.
if (newValue === "" || newValue === "-" || newValue.endsWith(".")) {
controllerField.onChange(newValue);
return;
}

const parsed = Number.parseFloat(newValue);
controllerField.onChange(
field.type === "number"
? Number.parseFloat(newValue).toString()
: newValue,
Number.isNaN(parsed) ? newValue : parsed.toString(),
Comment on lines +73 to +75

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

node - <<'NODE'
for (const value of ["1e", "1e-", "12abc", "1.2.3", "Infinity"]) {
  const parsed = Number.parseFloat(value);
  console.log(value, "=>", Number.isNaN(parsed) ? value : parsed.toString());
}
NODE

Repository: meshtastic/web

Length of output: 215

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate and inspect the target component around the reported lines.
printf '%s\n' '--- target file vicinity ---'
sed -n '1,120p' apps/web/src/components/Form/FormInput.tsx | cat -n

printf '%s\n' '--- focused relevant section ---'
sed -n '60,85p' apps/web/src/components/Form/FormInput.tsx | cat -n

printf '%s\n' '--- related tests/usages if present ---'
rg -n "FormInput|parseFloat|Number.isFinite|Number\\(" -S apps/web/src/components/Form apps/web/src 2>/dev/null | head -80 || true

Repository: meshtastic/web

Length of output: 6853

🏁 Script executed:

#!/bin/bash
set -euo pipefail

node - <<'NODE'
const cases = [
  "1e",
  "1e-",
  "12abc",
  "1.2.3",
  "Infinity",
  "Infinityabc",
  "-34.1147648",
  "-34.1147648abc",
  ".1147648",
  "+1.2.3",
  "-1.2.3",
  "",
  "-",
  ".",
  "-.",
  "-.",
];

console.log("parseFloat results:");
for (const value of cases) {
  const parsed = Number.parseFloat(value);
  const normalized = Number.isNaN(parsed) ? value : parsed.toString();
  console.log(JSON.stringify(value), "=>", JSON.stringify(parsed), "normalized =>", JSON.stringify(normalized));
}

console.log("\nNumber with full-string regex results:");
const floatRe = /^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?$/;
for (const value of cases) {
  const parsed = Number(value);
  const complete = Number.isFinite(parsed) && (value === "" || floatRe.test(value));
  console.log(
    JSON.stringify(value),
    "=>",
    JSON.stringify(parsed),
    "complete number =>",
    complete.toString().toLowerCase(),
    "normalized =>",
    JSON.stringify(complete ? parsed.toString() : value),
  );
}
NODE

Repository: meshtastic/web

Length of output: 1847

Validate the complete numeric string before normalizing.

Number.parseFloat(newValue) accepts numeric prefixes. "1e", "1e-", "12abc", and "1.2.3" are normalized to "1", "1", "12", and "1.2", so valid prefix text is lost. Valid Infinity text is also preserved through this path.

Use a Number.isFinite() parse result for valid strings and preserve intermediate empty, negative, or decimal-typing states separately. Add regression tests for "1e", "12abc", "Infinity", and -34.1147648.

Proposed fix 
-    const parsed = Number.parseFloat(newValue);
+    const parsed = Number(newValue);
+    const isCompleteNumber =
+      Number.isFinite(parsed) &&
+      /^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?$/.test(newValue);
     controllerField.onChange(
-      Number.isNaN(parsed) ? newValue : parsed.toString(),
+      isCompleteNumber ? parsed.toString() : newValue,
     );
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const parsed = Number.parseFloat(newValue);
controllerField.onChange(
field.type === "number"
? Number.parseFloat(newValue).toString()
: newValue,
Number.isNaN(parsed) ? newValue : parsed.toString(),
const parsed = Number(newValue);
const isCompleteNumber =
Number.isFinite(parsed) &&
/^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?$/.test(newValue);
controllerField.onChange(
isCompleteNumber ? parsed.toString() : newValue,
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/components/Form/FormInput.tsx` around lines 73 - 75, Update the
onChange normalization around parsed in FormInput so numeric validation covers
the complete newValue rather than accepting parseFloat prefixes. Preserve
intermediate empty, negative, and decimal-typing states, accept only finite
complete numeric values (including -34.1147648), and retain invalid text such as
"1e", "12abc", "1.2.3", and "Infinity"; add regression tests for the specified
cases.

);
};

Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/PageComponents/Settings/Position.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export const Position = ({ onFormInit }: PositionConfigProps) => {
properties: {
step: 0.0000001,
suffix: "Degrees",
fieldLength: { max: 10 },
fieldLength: { max: 11 },
},
disabledBy: [{ fieldName: "fixedPosition" }],
},
Expand All @@ -248,7 +248,7 @@ export const Position = ({ onFormInit }: PositionConfigProps) => {
properties: {
step: 0.0000001,
suffix: "Degrees",
fieldLength: { max: 10 },
fieldLength: { max: 12 },
},
disabledBy: [{ fieldName: "fixedPosition" }],
},
Expand Down
68 changes: 68 additions & 0 deletions apps/web/src/validation/config/position.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import { describe, expect, it } from "vitest";
import { PositionValidationSchema } from "./position.ts";

const validBase = {
positionBroadcastSecs: 0,
positionBroadcastSmartEnabled: false,
fixedPosition: false,
gpsUpdateInterval: 0,
positionFlags: 0,
rxGpio: 0,
txGpio: 0,
broadcastSmartMinimumDistance: 0,
broadcastSmartMinimumIntervalSecs: 0,
gpsEnGpio: 0,
gpsMode: 0,
};

describe("PositionValidationSchema", () => {
it("accepts positive latitude and longitude with 7 decimal places", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
latitude: 34.1147648,
longitude: 28.3166667,
});
expect(result.success).toBe(true);
});

it("accepts negative latitude and longitude with 7 decimal places", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
latitude: -34.1147648,
longitude: -122.4194165,
});
expect(result.success).toBe(true);
});

it("rejects latitude with more than 7 decimal places", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
latitude: -34.11476481,
});
expect(result.success).toBe(false);
});

it("rejects longitude with more than 7 decimal places", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
longitude: -122.41941654,
});
expect(result.success).toBe(false);
});

it("rejects latitude outside the valid range", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
latitude: 91,
});
expect(result.success).toBe(false);
});

it("rejects longitude outside the valid range", () => {
const result = PositionValidationSchema.safeParse({
...validBase,
longitude: -181,
});
expect(result.success).toBe(false);
});
Comment on lines +53 to +67

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Test both ends of each coordinate range.

These cases test only latitude values above 90 and longitude values below -180. A schema that accepts latitude below -90 or longitude above 180 still passes this suite. Add rejection tests for -91 and 181. Add acceptance tests for -90, 90, -180, and 180 if the documented bounds are inclusive.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/validation/config/position.test.ts` around lines 53 - 67, Extend
the tests around PositionValidationSchema to cover both sides of each coordinate
bound: reject latitude -91 and longitude 181, and verify the inclusive boundary
values -90, 90, -180, and 180 are accepted using validBase.

});
20 changes: 18 additions & 2 deletions apps/web/src/validation/config/position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ import { z } from "zod/v4";

const GpsModeEnum = z.enum(Protobuf.Config.Config_PositionConfig_GpsMode);

const maxDecimalPlaces = (places: number) => (value: number | undefined) => {
if (value === undefined) return true;
const [, decimals] = value.toString().split(".");
return !decimals || decimals.length <= places;
};
Comment on lines +6 to +10

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

node <<'NODE'
for (const value of [1e-7, 1.2e-7]) {
  const [, decimals] = value.toString().split(".");
  console.log({
    value,
    representation: value.toString(),
    currentResult: !decimals || decimals.length <= 7,
  });
}
NODE

Repository: meshtastic/web

Length of output: 278

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "== locate position.ts =="
fd 'position\.ts$' . | sed -n '1,20p'

echo "== file overview =="
for f in $(fd 'position\.ts$' .); do
  echo "--- $f"
  wc -l "$f"
  sed -n '1,80p' "$f" | cat -n
done

echo "== search schema/usages =="
rg -n "maxDecimalPlaces|positionSchema|position" apps/web/src/validation apps/web/src -S | sed -n '1,200p'

echo "== small value string forms for DecimalPlaces =="
node <<'NODE'
for (const places of [6,7,8,9]) {
  for (const value of [1e-7, 1.2e-7, 1.2345678e-2]) {
    const [, decimals] = value.toString().split(".");
    console.log(JSON.stringify({ value, places, toString: value.toString(), decimalFraction: decimals, currentResult: !decimals || decimals.length <= places }));
  }
}
NODE

Repository: meshtastic/web

Length of output: 27657

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "== inspect Zod/number coercion path if present =="
rg -n "preprocess|number\(\)|z\\.number|schema:|schema:" apps/web/src/validation apps/web/src/schema -S | sed -n '1,220p'

fd '.*\.ts$' apps/web/src/validation/apps/web/src/schema 2>/dev/null | xargs -r sed -n '1,180p' | sed -n '1,180p'

Repository: meshtastic/web

Length of output: 8156

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "== validate.ts =="
sed -n '1,80p' apps/web/src/validation/validate.ts | cat -n

echo "== settings position component relevant fields =="
sed -n '220,255p' apps/web/src/components/PageComponents/Settings/Position.tsx | cat -n

Repository: meshtastic/web

Length of output: 2320

Count decimal places across exponential notation.

Number.prototype.toString() can produce exponential form for small coordinates. split(".") then misses the exponent, so values like 1.2e-7 pass as only one decimal place when they represent eight. Handle the exponent explicitly or validate the original string before coercion.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/validation/config/position.ts` around lines 6 - 10, Update
maxDecimalPlaces to account for exponent digits when validating decimal
precision, rather than relying only on splitting value.toString() at the decimal
point. Ensure exponential values such as 1.2e-7 are rejected when their
effective decimal places exceed places, while preserving the existing undefined
and valid-precision behavior.


export const PositionValidationSchema = z.object({
positionBroadcastSecs: z.coerce.number().int().min(0),
positionBroadcastSmartEnabled: z.boolean(),
Expand All @@ -15,8 +21,18 @@ export const PositionValidationSchema = z.object({
broadcastSmartMinimumIntervalSecs: z.coerce.number().int().min(0),
gpsEnGpio: z.coerce.number().int().min(0),
gpsMode: GpsModeEnum,
latitude: z.coerce.number().min(-90).max(90).optional(),
longitude: z.coerce.number().min(-180).max(180).optional(),
latitude: z.coerce
.number()
.min(-90)
.max(90)
.optional()
.refine(maxDecimalPlaces(7), { message: "Max 7 decimal precision" }),
longitude: z.coerce
.number()
.min(-180)
.max(180)
.optional()
.refine(maxDecimalPlaces(7), { message: "Max 7 decimal precision" }),
Comment on lines +24 to +35

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

node <<'NODE'
for (const raw of ["", " ", "-", "34."]) {
  console.log(JSON.stringify({ raw, coerced: Number(raw) }));
}
NODE

Repository: meshtastic/web

Length of output: 253

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "Files:"
fd -a 'position\.ts|Position\.tsx' . | sed 's#^\./##'

echo
echo "position.ts outline:"
ast-grep outline apps/web/src/validation/config/position.ts || true

echo
echo "position.ts content:"
cat -n apps/web/src/validation/config/position.ts

echo
echo "Position.tsx relevant section:"
sed -n '120,185p' apps/web/src/components/PageComponents/Settings/Position.tsx | cat -n

echo
echo "Search position validation usages:"
rg -n "PositionValidationSchema|latitude|longitude" apps/web/src -g '*.ts' -g '*.tsx' | head -120

Repository: meshtastic/web

Length of output: 11787

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "DynamicForm definition locations:"
rg -n "DynamicForm|type .*FormProps|componentProps|ReactHTML|submit" -g '*.ts' -g '*.tsx' apps/web/src | head -200

echo
echo "Search for DynamicForm implementation:"
rg -n "export .*DynamicForm|function DynamicForm|const DynamicForm" apps/web/src -g '*.ts' -g '*.tsx'

Repository: meshtastic/web

Length of output: 18021

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "DynamicForm implementation:"
cat -n apps/web/src/components/Form/DynamicForm.tsx | sed -n '76,195p'

echo
echo "DynamicFormField implementation:"
cat -n apps/web/src/components/Form/DynamicFormField.tsx | sed -n '1,140p'

echo
echo "Position settings relevant input fields:"
cat -n apps/web/src/components/PageComponents/Settings/Position.tsx | sed -n '215,260p'

echo
echo "FormInput implementation:"
cat -n apps/web/src/components/Form/FormInput.tsx | sed -n '1,120p'

echo
echo "Root validation imports:"
cat -n apps/web/src/validation/config/position.ts | sed -n '1,60p'

echo
echo "Node coercion behavior for blank inputs:"
node - <<'NODE'
const inputs = ["", " ", "\t", "-"];
for (const value of inputs) {
  console.log(JSON.stringify({
    display: value || "<empty>",
    asNumberString: Number(String(value)),
    passedToNumberSchemaLike: Number(String(value)),
  }));
}
NODE

Repository: meshtastic/web

Length of output: 15398

Map empty coordinates to undefined before numeric coercion.

z.coerce.number() treats "" as 0 before .optional(), so clearing a latitude or longitude field can pass a defined zero coordinate to submit and later send a fixed position with that coordinate cleared to 0. Normalize blank strings to undefined before coercion, or update the form output contract and add tests for clearing one coordinate and both coordinates.

[low effort]

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/validation/config/position.ts` around lines 24 - 35, Update the
latitude and longitude schemas in the position validation definition to
normalize blank string inputs to undefined before numeric coercion, preserving
optional behavior for cleared fields. Ensure clearing either coordinate, or both
coordinates, produces undefined rather than numeric zero in the form output
consumed by submit.

altitude: z.coerce.number().optional(),
});

Expand Down
Loading