fix: improve zenuml print rendering, sizing, and syntax resilience#7567
Open
MrCoder wants to merge 2 commits intomermaid-js:developfrom
Open
fix: improve zenuml print rendering, sizing, and syntax resilience#7567MrCoder wants to merge 2 commits intomermaid-js:developfrom
MrCoder wants to merge 2 commits intomermaid-js:developfrom
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: f691124 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eb17992 to
c8978b2
Compare
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7567 +/- ##
=======================================
Coverage 3.34% 3.34%
=======================================
Files 524 526 +2
Lines 55392 55417 +25
Branches 795 796 +1
=======================================
+ Hits 1853 1854 +1
- Misses 53539 53563 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@zenuml/coreDetails
This change updates the Mermaid ZenUML integration to use native SVG output from
@zenuml/coreinstead of HTML insideforeignObject.That change addresses three user-facing problems:
Print rendering (#6004): Lifelines are rendered as SVG lines instead of HTML borders, so they continue to appear in print preview and PDF export.
Responsive sizing (#7266): ZenUML output now respects Mermaid's
useMaxWidthbehavior and stays within its container instead of forcing a fixed oversized SVG.Invalid syntax resilience (#7154): Invalid ZenUML no longer freezes the editor; rendering falls back to best-effort output instead.
Validation
pnpm exec vitest run packages/mermaid-zenuml/src/zenumlRenderer.spec.tspnpm exec tsc -p packages/mermaid-zenuml/tsconfig.json --noEmit