Skip to content

fix: correct extension marker dimensions for mobile/iOS rendering#7538

Open
cyphercodes wants to merge 1 commit intomermaid-js:developfrom
cyphercodes:develop
Open

fix: correct extension marker dimensions for mobile/iOS rendering#7538
cyphercodes wants to merge 1 commit intomermaid-js:developfrom
cyphercodes:develop

Conversation

@cyphercodes
Copy link
Copy Markdown

Issue

Fixes #7518

Problem

The extensionStart marker (used for implementation/realization arrows in class diagrams) had incorrect dimensions:

  • markerWidth was 190 (should be 20)
  • markerHeight was 240 (should be 28)

These typos caused the arrow markers to render incorrectly or not at all on mobile devices and iOS Safari.

Solution

Corrected the marker dimensions to match the extensionEnd marker and the margin variants:

  • markerWidth: 20
  • markerHeight: 28

Verification

This fix aligns the extensionStart marker with:

  • extensionEnd marker (already had correct values)
  • extensionStart-margin and extensionEnd-margin variants (already had correct values)
  • Other similar markers in the same file

The path data (M 1,7 L18,13 V 1 Z) expects a viewBox of approximately 20x14, so markerWidth=20 and markerHeight=28 are appropriate values.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: b804f7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b804f7e
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/69c63b3cb482360008dc5e02
😎 Deploy Preview https://deploy-preview-7538--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 27, 2026

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/@mermaid-js/examples@7538

mermaid

npm i https://pkg.pr.new/mermaid@7538

@mermaid-js/layout-elk

npm i https://pkg.pr.new/@mermaid-js/layout-elk@7538

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/@mermaid-js/layout-tidy-tree@7538

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/@mermaid-js/mermaid-zenuml@7538

@mermaid-js/parser

npm i https://pkg.pr.new/@mermaid-js/parser@7538

@mermaid-js/tiny

npm i https://pkg.pr.new/@mermaid-js/tiny@7538

commit: b804f7e

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.34%. Comparing base (e9d4c11) to head (b804f7e).

Files with missing lines Patch % Lines
...d/src/rendering-util/rendering-elements/markers.js 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7538      +/-   ##
==========================================
- Coverage     3.34%   3.34%   -0.01%     
==========================================
  Files          524     525       +1     
  Lines        55256   55267      +11     
  Branches       795     795              
==========================================
  Hits          1850    1850              
- Misses       53406   53417      +11     
Flag Coverage Δ
unit 3.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/src/rendering-util/rendering-elements/markers.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implementation/realization arrow not correctly rendered on mobile/iOS

1 participant