Skip to content

Bump node from 14-slim to 24-slim in /webapp #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump node from 14-slim to 24-slim in /webapp #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54665ec
Bump node from 14-slim to 24-slim in /webapp
dependabot[bot] May 16, 2025
71da59e
Merge branch 'main' into dependabot/docker/webapp/node-24-slim
WillGibson Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webapp/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM node:16 AS build
FROM node:24 AS build

@WillGibson WillGibson Jul 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places we would want to bump the Node.js version including...

https://github.com/mcagov/droits/blob/main/webapp/package.json#L5

https://github.com/mcagov/droits/blob/main/.tool-versions#L2

Note that the latter would also affect backoffice, so we would maybe override that in a webapp/.tool-versions file.


WORKDIR /srv
ADD . .
RUN rm -rf node_modules && npm install --cache /tmp/empty-cache

FROM node:16-slim
FROM node:24-slim

WORKDIR /srv
COPY --from=build /srv .
Expand Down