Record the Path disclosure ruling, and a script to reclaim the disk - #601
Open
maximsan wants to merge 4 commits into
Open
Record the Path disclosure ruling, and a script to reclaim the disk#601maximsan wants to merge 4 commits into
maximsan wants to merge 4 commits into
Conversation
ADR-0024, cited from the density that encodes it, plus a warning on the design doc paragraph that still states the prototype's rule — that paragraph is what a reconciliation reads, and without it the divergence reads as a bug.
Cuts the ported-then-corrected sequence from the Context, and a claim I had not checked: ADR-0016 already rules three Path surfaces away from the prototype, so this is not the first departure on the screen.
Reports by default and deletes only with --apply, behind an allow-list of the four paths it may take. Finds the main checkout through --git-common-dir, so it lists every worktree's build/ when run from inside one.
The table's single 'on arrival' column let the active module's 'open' read as 'always open', which is the opposite of the ruling. Capability and initial state are now two columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two records, both about work that was invisible until it bit.
#599 shipped a deliberate departure from
prototype/disclosure.jsx: everymodule a learner can reach carries a caret and opens and shuts, where the
design pins the active one open with no caret. That ruling lived only in a
merged PR body. ADR-0024 records it.
Separately, the machine ran out of disk mid-branch — 163 MB free of 460 GB,
enough that commands could not write their own output. An iOS Flutter build
never reclaims what it takes, and nothing in the repo said so or offered a way
out.
tool/clean_build_caches.shdoes both.Watch for
07-components.mdstill states theprototype's formula as the spec, and that paragraph is what someone reads
while porting the screen —
docs/adr/is not. The warning goes there, nextto the sentence it contradicts.
path_density.dartgains one clause, citing the ADR the way three filesnearby cite ADR-0016. No behaviour changes, hence
no-changelog: One disclosure draws every expandable section #599already logged what a learner sees.
safe_rmis an allow-list offour paths, not a "stay inside this tree" test — the looser version I wrote
first would have permitted
~/Library/Developer/Xcode/Archives, which theheader promises it never touches. Source, Archives and
~/.pub-cachearerefused; simulators are pruned with
delete unavailable, nevererase.--apply, and--worktreesis asecond opt-in because wiping a live worktree's
build/forces a rebuild onwhoever is using it.
origin/main.A concurrent session is drafting its own 0024 for the pricing arms; whichever
lands second renumbers, as
docs/adr/README.mdsays.Checks
adr_numbering_testpasses:0001–0024, no gaps, heading matches filename.Both new links resolve. The script was run from inside a worktree, where it
correctly resolved the main checkout and listed all six
build/directories;its path guard was exercised against eight paths, allowing four and refusing
lib/,Documents,Archives,.pub-cacheand/.