Skip to content

ci: find the libmavlink rlib in both Cargo layouts - #577

Merged
onur-ozkan merged 1 commit into
mavlink:masterfrom
Mattbusel:fix/measure-build-rlib-path
Nov 17, 2026
Merged

onur-ozkan merged 1 commit into
mavlink:masterfrom
Mattbusel:fix/measure-build-rlib-path

Conversation

@Mattbusel

Copy link
Copy Markdown
Contributor

build-metrics fails on every PR right now, in the "Measure base" step, with:

find: 'target/performance/release/deps': No such file or directory

The runner installs current stable, which is Rust 1.100.0 since Nov 9. Cargo 1.100 uses the build-dir layout, and target/performance/release/deps doesn't exist anymore. measure_build.sh searched that folder for libmavlink-*.rlib, so it can't find anything.

Fix: read $TARGET_DIR/release/libmavlink.rlib instead. Cargo writes that copy in both the old and new layouts. It's the same file, so the size numbers stay the same.

Results with scripts/measure_build.sh target/performance:

  • Rust 1.99.1: old script passes, new script passes, both report 107461088 bytes.
  • Rust 1.100.0: old script fails with the error above, new script passes.

Since the base step runs ../head/scripts/measure_build.sh, this fixes build-metrics for open PRs once they rebase.

measure_build.sh looked for release/deps/libmavlink-*.rlib. Since Rust
1.100 Cargo uses the build-dir layout and release/deps is gone, so
build-metrics fails in "Measure base" on every PR. Use
release/libmavlink.rlib instead, which Cargo writes in both layouts.
@onur-ozkan
onur-ozkan merged commit 8decce1 into mavlink:master Nov 17, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants