Repository navigation
ci: find the libmavlink rlib in both Cargo layouts - #577
Merged
Merged
Conversation
measure_build.sh looked for release/deps/libmavlink-*.rlib. Since Rust 1.100 Cargo uses the build-dir layout and release/deps is gone, so build-metrics fails in "Measure base" on every PR. Use release/libmavlink.rlib instead, which Cargo writes in both layouts.
onur-ozkan
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-metrics fails on every PR right now, in the "Measure base" step, with:
The runner installs current stable, which is Rust 1.100.0 since Nov 9. Cargo 1.100 uses the build-dir layout, and
target/performance/release/depsdoesn't exist anymore.measure_build.shsearched that folder forlibmavlink-*.rlib, so it can't find anything.Fix: read
$TARGET_DIR/release/libmavlink.rlibinstead. Cargo writes that copy in both the old and new layouts. It's the same file, so the size numbers stay the same.Results with
scripts/measure_build.sh target/performance:Since the base step runs
../head/scripts/measure_build.sh, this fixes build-metrics for open PRs once they rebase.