Skip to content

build(cmake): fail fast with clear diagnostic when .venv has no pip (5.1) - #14802

Merged
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:stable51-venv-pip
Aug 9, 2026
Merged

build(cmake): fail fast with clear diagnostic when .venv has no pip (5.1)#14802
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:stable51-venv-pip

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Cherry-pick of #14784 to Stable_V5.1.

A hand-rolled 'uv venv' (without --seed) creates a pip-less venv. QGC
reuses it and configure later dies inside the mavlink CPM build with an
opaque 'Python pip not found' error. Detect the missing pip up front and
fail with instructions instead.

Replaces mavlink#14767, which auto-bootstrapped pip via ensurepip; a read-only
diagnostic avoids CMake silently mutating a user-managed venv.
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Stable_V5.1@249ac77). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             Stable_V5.1   #14802   +/-   ##
==============================================
  Coverage               ?   32.68%           
==============================================
  Files                  ?      784           
  Lines                  ?    67602           
  Branches               ?    31311           
==============================================
  Hits                   ?    22093           
  Misses                 ?    30632           
  Partials               ?    14877           
Flag Coverage Δ
unittests 32.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249ac77...bf63c70. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 119 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 119 passed, 0 skipped
Total: 295 passed, 0 skipped

Code Coverage

Coverage: 69.4%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.78 MB
QGroundControl-aarch64 179.35 MB
QGroundControl-installer-AMD64 137.85 MB
QGroundControl-installer-AMD64-ARM64 80.38 MB
QGroundControl-installer-ARM64 109.14 MB
QGroundControl-linux 87.04 MB
QGroundControl-mac 87.04 MB
QGroundControl-x86_64 191.59 MB
No baseline available for comparison

Updated: 2026-08-09 17:06:42 UTC • Commit: bf63c70 • Triggered by: Android

@DonLakeFlyer
DonLakeFlyer merged commit 2512759 into mavlink:Stable_V5.1 Aug 9, 2026
44 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the stable51-venv-pip branch August 9, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant