make round be round-ties-even, miscellaneous changes to the rounding procedures#530
Merged
Merged
Conversation
previously the (floor) and (ceiling) docs were worded very differently, so align them to better match eachother. additionally reword the error message for (floor) to also align them with the rest of the rounding procedures.
m4rch3n1ng
force-pushed
the
round-ties-even
branch
from
092ae12 to
c06f599
Compare
mattwparas
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the scheme spec states, that "[t]he round procedure rounds to even". num-rational does not provide a
round_ties_even, so i implemented it myself (and submitted a pr upstream: rust-num/num-rational#141, though i do not know if or when that will be merged, as num-rational has not had a commit in over a year).the rest of the changes are largely tests, docs and minor adjustments, that should be relatively clear just from the commit messages.