fix(packaging): download sherpa-onnx module before resolving its path - #51
Open
alohaninja wants to merge 1 commit into
Open
fix(packaging): download sherpa-onnx module before resolving its path#51alohaninja wants to merge 1 commit into
alohaninja wants to merge 1 commit into
Conversation
go list -m returns empty on a fresh clone because the module cache is unpopulated; add go mod download first so the directory can be resolved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle-dylibs.shcalledgo list -mto find the sherpa-onnx dylib directory, but on a fresh clone the module isn't in the cache yet —go listsilently returns empty, causingLIBDIRto expand to/lib/aarch64-apple-darwinand the build to failgo mod download github.com/k2-fsa/sherpa-onnx-go-macosbeforego listso the module is always in the cache before we try to resolve its directoryStartup Error
Notes
This doesn't affect the lazy-load design: the dylibs still ship in
Contents/Frameworksat build time (required so dlopen can find them when Parakeet is selected), and the model file is still fetched on first use. Thego mod downloadjust makes the existing implicit dependency explicit.Test plan
go listreturned empty)make appsucceeds after fix (module downloaded, dylibs bundled, app signed)make cipasses (build + vet + race tests)🤖 Generated with Claude Code