fix: check for go in setup and install via Homebrew if missing - #44
Merged
Conversation
make start (via setup) checked for brew, sox/ffmpeg, and whisper-cpp but not go itself. On a machine without Go, start would proceed to the build step and fail with a cryptic error: go build -o bin/vox ./cmd/vox make: go: No such file or directory make: *** [build] Error 1 Add a go existence check to the setup target that installs go via Homebrew when missing, matching the existing pattern for the other system dependencies. Update the README dep list to match. Fixes mattthewong#43
Address PR review feedback: - Quick-start Requirements line listed Go 1.24+ as a hard prerequisite, contradicting the auto-install step. Reframe to macOS + Homebrew as the only true requirements; go/sox/whisper-cpp are installed automatically. - Manual setup 'brew install' omitted go, so users following the manual path would still hit the cryptic build error this PR fixes. Add go.
Collaborator
Author
|
Addressed the two README suggestions in 14482cf:
On the Go version nit: leaving existence-only to stay consistent with the |
wprezioso
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make start(via thesetuptarget) checks forbrew,sox/ffmpeg, andwhisper-cpp, but never checks for Go itself. On a machine without Go installed,startproceeds to the build step and fails with a cryptic error:Change
goexistence check to thesetuptarget that installs Go via Homebrew when missing, matching the existing pattern used forsoxandwhisper-cpp.go.The check is placed right after the
brewguard since Go is required before the build step. Idempotent — skipped when Go is already onPATH.Validation (local)
make check-fmt— cleanmake build— succeedsmake lint(go vet) — cleangofromPATH; confirmed the install branch fires (brew install go) and is skipped when Go is present.Fixes #43