free leaked schema string in GetFilename#1408
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1408 +/- ##
==========================================
+ Coverage 47.16% 51.57% +4.41%
==========================================
Files 12 13 +1
Lines 1533 1869 +336
==========================================
+ Hits 723 964 +241
- Misses 669 744 +75
- Partials 141 161 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFilename hands the result of C.CString straight to sqlite3_db_filename, which only borrows the pointer, so the allocation is never released and a little C heap is leaked on every call. It is the only place in the package that builds a C string for an sqlite3 call without a matching free, the siblings all defer it. Stored the pointer and freed it the same way so the schema name no longer leaks.