Skip to content

Keep paginating /messages until no end token#823

Merged
MadLittleMods merged 2 commits intomainfrom
madlittlemods/messages-done-only-when-no-end
Dec 1, 2025
Merged

Keep paginating /messages until no end token#823
MadLittleMods merged 2 commits intomainfrom
madlittlemods/messages-done-only-when-no-end

Conversation

@MadLittleMods
Copy link
Copy Markdown
Collaborator

@MadLittleMods MadLittleMods commented Nov 25, 2025

Per the spec, keep paginating /messages until no end token.

Note that an empty chunk does not necessarily imply that no more events are available. Clients should continue to paginate until no end property is returned.

-- https://spec.matrix.org/v1.16/client-server-api/#get_matrixclientv3roomsroomidmessages

Pull Request Checklist

@MadLittleMods MadLittleMods changed the title Keep paginating /messges until no end token Keep paginating /messages until no end token Nov 25, 2025
@MadLittleMods MadLittleMods marked this pull request as ready for review November 25, 2025 22:28
@MadLittleMods MadLittleMods requested review from a team as code owners November 25, 2025 22:28
Comment thread tests/csapi/room_messages_test.go
@MadLittleMods MadLittleMods merged commit 65e78cd into main Dec 1, 2025
4 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/messages-done-only-when-no-end branch December 1, 2025 20:26
@MadLittleMods
Copy link
Copy Markdown
Collaborator Author

Thanks for the review @anoadragon453 🦐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants