ci: filter the push trigger to main, like the other three C libraries - #21
Merged
Conversation
ci.yml used a bare `on: push:` with no filter, so the full matrix fired on every branch AND every tag. A branch push plus its pull request ran the whole thing twice, and every release tag ran it a third time. netcode, reliable and yojimbo all filter to main; serialize was the odd one out. Not a correctness problem, just duplicated spend -- but CI spend is real money here and the steady state is meant to be deliberate rather than accidental. SAFE TO REMOVE THE TAG RUNS: release-check.yml already handles tags explicitly with `tags: [ 'v*' ]`, so tag coverage does not depend on ci.yml's unfiltered trigger. I checked that before changing it rather than after. workflow_dispatch added deliberately. Filtering push to main removes the ability to run CI on a feature branch by pushing to it; that capability should be replaced rather than quietly dropped, and dispatch makes it explicit instead of accidental. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.ymlused a bareon: push:with no filter, so the full matrix fired on every branch and every tag. A branch push plus its pull request ran the whole thing twice, and every release tag ran it a third time.netcode, reliable and yojimbo all filter to
main.serializewas the odd one out.Not a correctness problem — just duplicated spend. But CI spend is real money here, and the steady state is meant to be deliberate rather than accidental.
Safe to drop the tag runs:
release-check.ymlalready handles tags explicitly withtags: [ 'v*' ], so tag coverage does not depend onci.yml's unfiltered trigger. Checked before changing it, not after.workflow_dispatchadded deliberately: filtering push to main removes the ability to run CI on a feature branch by pushing to it. That capability should be replaced rather than quietly dropped.