VersionFull: 1.4.0 -> 1.4.3 - #20
Merged
Merged
Conversation
The CI guard caught this the moment netcode 1.4.3 shipped today, which is exactly
what it was added for.
VERIFIED NOT TO OVERCLAIM, per the precedent set when this constant was last bumped.
Every commit touching netcode.c/netcode.h between v1.4.0 and v1.4.3 was examined:
4296388 sodium hardenings -- the 107 lines added to netcode.c are
test_crypto_aead_vectors(), a TEST, not library behaviour. The vendored
libsodium is also irrelevant here: netcode.go uses Go's
chacha20poly1305, not a vendored C subset.
39f83f9 test-only (bind ephemeral ports)
753c09e crediting text
779532d/46d3a1e/bbda10a version bumps
ecdba96 THE ONLY FUNCTIONAL CHANGE -- netcode_generate_connect_token now bounds
num_server_addresses at runtime instead of relying on asserts that
-DNDEBUG removes.
And netcode.go ALREADY had that check, at token.go:296-298, returning an error for
a count outside [1, MaxServersPerConnect]. So the Go port was correct the whole time
and the C library was the outlier -- which is worth recording, because the C fix was
filed as a defect today and this port never had it.
So 1.4.3 is an accurate compatibility claim, not an aspirational one.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VersionFull matches upstreamguard fired the moment netcode 1.4.3 shipped today — which is precisely what it was added for.Verified not to overclaim
Per the precedent from the last bump, every commit touching
netcode.c/netcode.hbetweenv1.4.0andv1.4.3was examined:4296388netcode.caretest_crypto_aead_vectors(), a test. Also moot here: netcode.go uses Go'schacha20poly1305, not a vendored C subset.39f83f9753c09e779532d,46d3a1e,bbda10aecdba96netcode_generate_connect_tokennow boundsnum_server_addressesat runtime instead of relying on asserts that-DNDEBUGremovesAnd this port already had that check
token.go:296-298already returns an error for a count outside[1, MaxServersPerConnect].So the Go port was correct the whole time and the C library was the outlier — worth recording, since that C gap was filed as a defect and fixed today (netcode#173). Nothing to port here; the version claim was simply stale.
go buildandgo test ./...pass.This also unblocks #19, which the same guard was failing.
Note: the first version of this PR body was written with a bare
--body "..."and zsh executed the backticked terms inside it, blanking three of them. Rewritten via--body-file. That is my own crystallized invariant cx-0011 — prose in a double-quoted shell arg is executed — and I broke it anyway.🤖 Generated with Claude Code