Allowing options.locals to be specified to pass in parameters for vie…#13
Open
engineersamuel wants to merge 2 commits intomartyjs:masterfrom
Open
Allowing options.locals to be specified to pass in parameters for vie…#13engineersamuel wants to merge 2 commits intomartyjs:masterfrom
engineersamuel wants to merge 2 commits intomartyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to integrate react-starter (webpack) + marty isomorphism and needed to pass various parameters to the view engine (ejs) however the current build hardcoded the starting locals as {}. This will allow passing options like so (based on the martyjs ex):
Where the index.ejs contains:
In this instance the SCRIPT_URL is generated by webpack hot dev mode:
Also adding an ability to pass a blacklist of regular expressions for things such as API. It is very basic, feel free to improve upon it, but just an array over
/something/.test(req.url)