Skip to content

Handle errors, add go.mod, add .gitignore#9

Open
f-ewald wants to merge 8 commits into
marouni:masterfrom
f-ewald:master
Open

Handle errors, add go.mod, add .gitignore#9
f-ewald wants to merge 8 commits into
marouni:masterfrom
f-ewald:master

Conversation

@f-ewald

@f-ewald f-ewald commented May 19, 2022

Copy link
Copy Markdown

I added a go.mod and I propose to use go modules going forward. I also made the project dependent on go 1.18 as I am planning to make further changes that will require a fairly recent version, mostly //go:embed. .gitignore was added because I am importing this into my IDE.

Please let me know what you think about these changes and if I can contribute further.

@marouni marouni left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @f-ewald for your suggestion and efforts.

I'll take some in the coming days to build and test the changes.

Do you see any Readme chages worth mentioning ?

Comment thread go.mod Outdated
@@ -0,0 +1,17 @@
module github.com/f-ewald/adr

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f-ewald Would it be possible to put the /marouni/ path here ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change this.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @f-ewald
I'll rebuild test and get back to you ASAP

@f-ewald f-ewald requested a review from marouni November 22, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants