[GEN-8772] mark marinade-finance unpublished so consumers stop reporting it unlicensed - #94
Draft
janlegner wants to merge 1 commit into
Draft
[GEN-8772] mark marinade-finance unpublished so consumers stop reporting it unlicensed#94janlegner wants to merge 1 commit into
janlegner wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016c6JBdg7efaP7bzpQC4KWV
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
publish = falsetoprograms/marinade-finance/Cargo.toml, which is what the org policy'slicenses.private.ignore = truekeys off; alicensefield is not the route here becauseLICENSE.mdis a Medium Rare Foundation non-commercial licence with no SPDX identifier on the org allow list, so that would need a legal decision.Measured with cargo-deny 0.20.2 against the org
deny.tomlCI fetches (.githubbranchclaude/static-analysis-required-wrapper, sha25659f94fbf…), A/B in each consumer against two local git sources differing only by this line at themainnettip47a002e: marinade-common-rs-clilicenses FAILED(1 unlicensed error) →licenses ok, marcrank 5 → 4 unlicensed errors, validator-manager 5 → 4, liquid-staking-referral-program 3 → 2, and in this repo itself thelicenseserrors drop 2 → 1.Nothing else turns green: marcrank and validator-manager keep
dynsigner,marinade-client-rs,marinade-common-cli(marinade-common-rs-cli#28) andsolana-transaction-executor(solana-transaction-executor#11/#13), and here the remaininglicenseserror is the GPL-3.0array-byteshost-only dependency, which is a legal call.branch = "mainnet", so this is the ref that reaches them — the companion #95 againstmaindoes not, sincemainis an ancestor ofmainnetand not the other way round; note also that no check runs attach to PRs based onmainnet, so this ref currently gets no CI at all.