Skip to content

fix(ios): evict stale FetchCache entries on barrier queue #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riteshshukla04 merged 1 commit into from
Apr 11, 2026
Merged

fix(ios): evict stale FetchCache entries on barrier queue #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/react-native-nitro-fetch/ios/FetchCache.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,24 @@ final class FetchCache {

static func getResultIfFresh(_ key: String, maxAgeMs: Int64) -> NitroResponse? {
var out: NitroResponse?
var shouldEvict = false
queue.sync {
if let entry = results[key] {
let age = Int64(Date().timeIntervalSince1970 * 1000) - entry.timestampMs
if age <= maxAgeMs {
out = entry.response
} else {
results.removeValue(forKey: key)
shouldEvict = true
}
}
}
if shouldEvict {
queue.async(flags: .barrier) {
if let entry = results[key] {
let age = Int64(Date().timeIntervalSince1970 * 1000) - entry.timestampMs
if age > maxAgeMs {
results.removeValue(forKey: key)
}
}
}
}
Expand Down
Loading