Repository navigation
chore(release): bastion 0.2.4 - #6
Merged
Merged
Conversation
Ships #5: the IO.NetListen capability declarations every module importing HttpServer now needs, the FileError adaptations, the ambiguous-constructor qualifications, and Form.render's parameter reorder. Needed as a RELEASE, not just a merge: forgepm resolves bastion from the registry (`bastion = "0.2.3"`), so its CI still typechecks the published 0.2.3 sources and fails on exactly the errors #5 fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line version bump so #5 can be published. Same shape as
1fe0589(0.2.3) andde86e38(0.2.2).Why a release is required, not just the merge
forgepm resolves bastion from the registry (
bastion = "0.2.3"in its forge.toml), not from git. Its CI therefore still typechecks the published 0.2.3 sources and fails inside~/.march/cas/deps/bastion/on precisely the errors #5 fixed:needs IO.NetListen(health,island_assets,router,cache,session,island_socket)Headerinbastion_idempotencyForm.render'sIOList/StringsignatureFileErrorinforge/projectandforge/lowerMerging #5 does not move that; publishing does.
Verified against this content
Toolchain built from march
dd20b0ea(#114/#115/#116), depot frommain, CAS wiped and refetched:forge buildclean, 369 tests, 0 failuresforge checkclean,forge buildclean, 544 tests, 0 failures — the full count, matching the pre-regression baselineWorth a look before publishing
#5 changed a public API:
Form.Wrapper.rendermovedrender_innerahead of the defaulted params, because a required parameter after defaulted ones does not type-check. I updated the only call sites that exist (bastion's own tests). It ships in this release, so it deserves a deliberate decision rather than riding along.