Repository navigation
Embeddings: tests, new apis and return type fix - #108
Merged
Merged
Conversation
|
|
Linux debug test results 8 files 8 suites 11m 25s ⏱️ Results for commit 7b3e281. ♻️ This comment has been updated with latest results. |
Windows test results 5 files 5 suites 16m 14s ⏱️ Results for commit 7b3e281. ♻️ This comment has been updated with latest results. |
Linux release test results 8 files 8 suites 6m 23s ⏱️ Results for commit 7b3e281. ♻️ This comment has been updated with latest results. |
4 tasks done
- Add comprehensive unit and integration tests for models, errors, FFI, memory management, and concurrency - Fix error type display and propagation for clarity and robustness - Improve code formatting, imports, and test module organization - Add INSTRUCTIONS.md with usage, error handling, and testing guidance - Update .gitignore to exclude cache and relative directories
- Add GitHub Actions job to run clippy with warnings as errors - Enforce code formatting check with cargo fmt - Run unit tests and conditional OpenAI integration tests - Cache cargo dependencies for faster workflow runs - Make build job depend on successful quality checks
- Support multiple Jina and Voyage model variants - Implement API key and model validation - Define hidden size and max input length per model - Add prediction support and error handling - Add comprehensive unit and integration tests - Update CI to conditionally run Jina and Voyage tests
donhardman
force-pushed
the
fix/embedding-lib
branch
from
August 18, 2025 04:47
d3f21eb to
5636679
Compare
glookka
requested changes
Aug 19, 2025
glookka
left a comment
glookka
left a comment
Contributor
There was a problem hiding this comment.
I updated knn code to load library v2. However, the issue is still there - when trying to generate embeddings, the library returns an empty vector (an error is expected).
Contributor
|
quality checks fail |
- Add detailed error code mapping for Jina and Voyage API responses - Handle alternative error formats with specific LibError variants - Validate non-empty embeddings and individual embedding dimensions for Jina and Voyage - Add result presence checks and error returns in local model embedding aggregation - Fix unwrap calls to safely handle missing or invalid numeric values in embeddings
donhardman
force-pushed
the
fix/embedding-lib
branch
from
August 19, 2025 15:49
eb6a7ab to
c96d2ae
Compare
Collaborator
|
Blocked by #102 |
sanikolaev
pushed a commit
to manticoresoftware/manticoresearch
that referenced
this pull request
Aug 27, 2025
Bumps MCL version in deps.txt to 8.0.3 which includes a couple fixes related with auto-embeddigs. Related PRs: 8.0.2 - manticoresoftware/columnar#109 8.0.3 - manticoresoftware/columnar#108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.