freeze: support float operand numbers in feature serialization

[blenbot]

Summary

While going through capa/feature/freeze/features.py I noticed OperandNumber branch does an assertion which is assert isinstance(f.value, int) but capa.features.insn.OperandNumber accepts either int/float type for it's value.

This leads to serializing a valid feature such as OperandNumber(0, 1.5) to fail.

Changes

• Update freeze conversion/type handling for OperandNumber to accept int or float.

Checklist

• No CHANGELOG update needed

• No new tests needed

• No documentation update needed

• This submission includes AI-generated code and I have provided details in the description.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a serialization bug in the freeze component where OperandNumber features containing floating-point values could not be properly serialized. The changes ensure that the system correctly handles both integer and float types for operand numbers, improving the robustness of feature freezing and preventing unexpected failures during serialization.

Highlights

• Feature Serialization: Updated the freeze conversion and type handling for OperandNumber to correctly accept both int and float values, resolving an issue where valid float-based operand numbers would fail serialization due to an assertion expecting only integers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly extends support for floating-point values in OperandNumber features during serialization and deserialization. The changes align capa's freezing mechanism with the feature definition, which already supported both integers and floats. My review includes a minor suggestion to improve code consistency. It would also be beneficial to add a regression test for OperandNumber with a float value in test_serialize_features to prevent future regressions.

[williballenthin]

hm we should add a test case for a program that has a float as an operant. tbh i'm not sure how that looks or whether this even works. then we can use that example to drives fixes like this. would you be willing to do this @blenbot

[blenbot]

hm we should add a test case for a program that has a float as an operant. tbh i'm not sure how that looks or whether this even works. then we can use that example to drives fixes like this. would you be willing to do this @blenbot

Seems fair, I will do that first @williballenthin