Skip to content

fix auto-format workflow premature exit from isort#2935

Closed
231B145-JUET wants to merge 2 commits intomandiant:masterfrom
231B145-JUET:fix-isort-error-exit
Closed

fix auto-format workflow premature exit from isort#2935
231B145-JUET wants to merge 2 commits intomandiant:masterfrom
231B145-JUET:fix-isort-error-exit

Conversation

@231B145-JUET
Copy link
Copy Markdown

@231B145-JUET 231B145-JUET commented Mar 17, 2026

Description

Fixes a bug in the black-format GitHub Action workflow where the job exits prematurely during the isort step.

Motivation and Context
In PR #2883, the auto-format workflow was introduced to run both isort and black. However, if isort actually applies formatting changes to files, the pre-commit run isort command naturally returns a non-zero exit code. GitHub Actions interprets this as a step failure and aborts the entire workflow immediately. As a result, the workflow never reached the black formatting step or the final step to commit and push the changed files.

Changes

  • Added continue-on-error: true to the Run isort step in .github/workflows/black-format.yml. This mirrors the behavior of the Run black step and allows the workflow to proceed to the commit phase even when isort modifies files.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed
  • This submission includes AI-generated code and I have provided details in the description.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 17, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot dismissed their stale review March 17, 2026 06:35

CHANGELOG updated or no update needed, thanks! 😄

@231B145-JUET 231B145-JUET changed the title ci: fix auto-format workflow premature exit from isort fix auto-format workflow premature exit from isort Mar 17, 2026
@mike-hunhoff
Copy link
Copy Markdown
Collaborator

@231B145-JUET please address CLA failure.

@231B145-JUET
Copy link
Copy Markdown
Author

Thanks @mike-hunhoff , I am debugging the root cause of this issue on why it is happening, as I have already signed it upon opening, I apologize for the inconvenience and issue caused.

Thanks for understanding.

@mike-hunhoff
Copy link
Copy Markdown
Collaborator

superseded by #2992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants