fix auto-format workflow premature exit from isort#2935
fix auto-format workflow premature exit from isort#2935231B145-JUET wants to merge 2 commits intomandiant:masterfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
CHANGELOG updated or no update needed, thanks! 😄
|
@231B145-JUET please address CLA failure. |
|
Thanks @mike-hunhoff , I am debugging the root cause of this issue on why it is happening, as I have already signed it upon opening, I apologize for the inconvenience and issue caused. Thanks for understanding. |
|
superseded by #2992 |
Description
Fixes a bug in the
black-formatGitHub Action workflow where the job exits prematurely during theisortstep.Motivation and Context
In PR #2883, the auto-format workflow was introduced to run both
isortandblack. However, ifisortactually applies formatting changes to files, thepre-commit run isortcommand naturally returns a non-zero exit code. GitHub Actions interprets this as a step failure and aborts the entire workflow immediately. As a result, the workflow never reached theblackformatting step or the final step to commit and push the changed files.Changes
continue-on-error: trueto theRun isortstep in .github/workflows/black-format.yml. This mirrors the behavior of theRun blackstep and allows the workflow to proceed to the commit phase even whenisortmodifies files.Checklist