Skip to content

Fix failing tests failing in debug because of ARCTICDB_DEBUG_CHECK fring before an excepcted exception#3144

Open
vasil-pashov wants to merge 1 commit into
masterfrom
vasil.pashov/fix-debug-check
Open

Fix failing tests failing in debug because of ARCTICDB_DEBUG_CHECK fring before an excepcted exception#3144
vasil-pashov wants to merge 1 commit into
masterfrom
vasil.pashov/fix-debug-check

Conversation

@vasil-pashov

Copy link
Copy Markdown
Collaborator

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@vasil-pashov vasil-pashov added patch Small change, should increase patch version no-release-notes This PR shouldn't be added to release notes. labels Jun 2, 2026
@claude

claude Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

ArcticDB Code Review Summary

The code change itself is correct and minimal: swapping the call order ensures fix_normalization_or_throw raises the user-facing E_INCOMPATIBLE_OBJECTS exception before check_multiindex_matches' ARCTICDB_DEBUG_CHECK macros can assertion-fail in debug builds. The swap is safe — check_normalization_index_match is read-only, and the mutation fix_normalization_or_throw performs on rowcount normalization data does not affect inputs read by check_normalization_index_match.

PR Title & Description

  • Title contains typos: "fring" → "firing", "excepcted" → "expected", and "failing tests failing" is duplicated. Suggest: Fix ARCTICDB_DEBUG_CHECK firing before expected exception in fix_descriptor_mismatch_or_throw
  • Description is empty — the template's What does this implement or fix? section should briefly explain that check_normalization_index_match was running before fix_normalization_or_throw, causing debug assertions in check_multiindex_matches to fire on input-type mismatches before the proper E_INCOMPATIBLE_OBJECTS exception could be thrown.

Testing

  • No new test added. The PR title implies existing debug-mode tests already demonstrate the regression and will pass after this fix; if that is correct, this is acceptable. Otherwise please add a test exercising the df-vs-series (or similar input-type mismatch) path through fix_descriptor_mismatch_or_throw under a debug build to lock in the ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release-notes This PR shouldn't be added to release notes. patch Small change, should increase patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants