Skip to content

Fix GH token warning in persistence storage #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phoebusm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GH token warning in persistence storage #2931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ jobs:
name: Cleanup persistent storages
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {contents: read}
with:
job_type: cleanup
persistent_storage: ${{ needs.storage_type.outputs.storage }}
Expand All @@ -235,7 +236,7 @@ jobs:
name: Seed Persistent Storage for 3.${{matrix.python3}} Linux with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: seed
python3: ${{matrix.python3}}
Expand All @@ -260,7 +261,7 @@ jobs:
name: Seed Persistent Storage for 3.${{matrix.python3}} Windows with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: seed
python3: ${{matrix.python3}}
Expand All @@ -284,7 +285,7 @@ jobs:
name: Seed Persistent Storage for 3.${{matrix.python3}} MacOS with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: seed
python3: ${{matrix.python3}}
Expand Down Expand Up @@ -410,7 +411,7 @@ jobs:
name: Verify Persistent Storage for 3.${{matrix.python3}} Linux with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: verify
python3: ${{matrix.python3}}
Expand All @@ -434,7 +435,7 @@ jobs:
name: Verify Persistent Storage for 3.${{matrix.python3}} Windows with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: verify
python3: ${{matrix.python3}}
Expand Down Expand Up @@ -486,7 +487,7 @@ jobs:
name: Verify Persistent Storage for 3.${{matrix.python3}} MacOS with ${{ matrix.arcticdb_version }} ArcticDB package version
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {packages: write}
permissions: {contents: read}
with:
job_type: verify
python3: ${{matrix.python3}}
Expand All @@ -501,6 +502,7 @@ jobs:
name: Cleanup persistent storages
uses: ./.github/workflows/persistent_storage.yml
secrets: inherit
permissions: {contents: read}
with:
job_type: cleanup
persistent_storage: ${{ needs.storage_type.outputs.storage }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/persistent_storage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
arcticdb_version: {default: "", type: string, description: The version of ArcticDB that will be installed and used for seed/verify }
persistent_storage: {required: true, default: "no", type: string, description: Specifies whether the python tests should tests against real storages e.g. AWS S3 }

permissions:
contents: read

jobs:
setup:
if: inputs.job_type != 'cleanup'
Expand Down
Loading