chore: update project version to 161 and revise npm setup script for … - #1532
Merged
Conversation
…root git permissions
dotenv-webpack and base64-loader are only ever loaded by webpack.config.js, but declaring them runtime dependencies pulled webpack — and with it browserslist — into the tree `npm audit --omit=dev` walks. Two browserslist advisories therefore failed the blocking audit gate over code that is never part of the shipped extension. The react-router allowlist entry no longer matches any reported advisory, so the gate asks for its removal.
The Chrome suite ran on Playwright's default 30s per-test budget, but the vault-creation scenario spends it on a password, a generated phrase, a 12-word confirmation and then the popup. On a loaded runner it ran out mid-click and surfaced as "Target page, context or browser has been closed", which reads like a crashed browser rather than the timeout it is.
The suite has grown past eight minutes on a loaded machine, and the same gate already blocks the merge in CI. The hook keeps the fast static checks, which is what catches a typo before it costs a CI round-trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…root git permissions
Make sure to fill in all the below sections.
Description
// Provide a useful description of this PR, aimed at helping reviewers and contributors
Linked tickets
WALLET-XXX
Checklist
Make sure this PR title follows semantic release conventions: https://semantic-release.gitbook.io/semantic-release/#commit-message-format
If the PR adds any new text to the UI, make sure they are localized
Include a screenshot or recording if implementing significant UI or user flow change
When this PR affects architecture changes wait for review from Dmytro before merging