Skip to content

Feat: xy pads WIP#6

Draft
bboettcher3 wants to merge 2 commits into
magnetophon:mainfrom
bboettcher3:feat/xy_pad
Draft

Feat: xy pads WIP#6
bboettcher3 wants to merge 2 commits into
magnetophon:mainfrom
bboettcher3:feat/xy_pad

Conversation

@bboettcher3

Copy link
Copy Markdown

Adds 2 XY pads, one controlling attack and attack shape, the other for the corresponding release params.

Still a WIP as it needs to work with all 3 zoom modes.

@bboettcher3

Copy link
Copy Markdown
Author

Things that still need addressing:

  • Thumb drawing when near bounds is sometimes clipped for some reason
  • Thumb isn't over the curve, but it probably should be? (or how to display thumb generally)
  • Gracefully handling all 3 zoom modes (XY pads currently scale their width, which is only how relative behaves)

@magnetophon

magnetophon commented Apr 8, 2024

Copy link
Copy Markdown
Owner

Thank you very much for this great addition!

  • Thumb drawing when near bounds is sometimes clipped for some reason

For me, the Thumbs are always clipped at max attack or release time:

lamb_xy_pad.mp4

In general, the thumb doesn't line up yet.
Does yours behave the same, or is there something wrong on my system only?

  • Thumb isn't over the curve, but it probably should be? (or how to display thumb generally)

You mean that you think the thumb should be always on the line of the curve?
I'm not sure if that's possible, except for in absolute mode.
Not sure if it's desirable, I can imagine you wouldn't have enough resolution in the low time ranges, since you'd miss the skew factor that we currently have.
Maybe I misunderstood.

  • Gracefully handling all 3 zoom modes (XY pads currently scale their width, which is only how relative behaves)

Mine don't seem to scale their width.
As you can see in this clip, the shortest release is always in the same position, independent from what the attack is set to:

lamb_xy_scale.mp4

Does yours behave differently?
Did I misunderstand your goal?

@magnetophon magnetophon force-pushed the main branch 5 times, most recently from bcfcc19 to 8cf115f Compare April 11, 2024 08:37
@magnetophon

Copy link
Copy Markdown
Owner

Congratulations on the merge: vizia/vizia#470!
NIH-plug uses an older VIZIA version, how can we get your XY-pad in lamb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants