ci: run docs-fix via Docker and track its Node version with Dependabot#68
Merged
Merged
Conversation
- docs-fix.yml: drop runner-native setup-node@18 / setup-python / 'yarn install' (redundant + broken: precommit_fix already runs markdownlint in a container, and there is no root package.json). Now: checkout -> make -C readmes precommit_fix -> capture/upload patch. - readmes/Dockerfile: node:20.16 -> node:26-slim (aligns with the docusaurus image) - dependabot.yml: track /readmes (docker) so the markdownlint image's Node version is bumped automatically instead of rotting in a workflow input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the
docs-fixworkflow fully Docker-based and put its Node version under Dependabot.setup-node@18,setup-python, andyarn installsteps. They were redundant (the fix already runs markdownlint insidereadmes/Dockerfile) and broken (yarn installran at the repo root, which has nopackage.json). The job is now: checkout ->make -C readmes precommit_fix(Dockerized) -> capture/upload the patch.node:20.16->node:26-slim, aligning with the docusaurus image.dockerentry for/readmesso the markdownlint image Node version is bumped automatically.Why
A
node-version:workflow input is not updated by Dependabot (it tracksuses:tags and DockerfileFROM, not action inputs) — which is why it sat at 18. Pinning Node in a Dockerfile and tracking that directory keeps it maintainable.Validation
Built
readmes/Dockerfileonnode:26-slim;markdownlint --version-> 0.48.0 (tooling works on Node 26).