V1: Feature: Add End 2 End tests#141
Open
Davycontrolaltdelete wants to merge 1 commit intomagewirephp:1.xfrom
Open
V1: Feature: Add End 2 End tests#141Davycontrolaltdelete wants to merge 1 commit intomagewirephp:1.xfrom
Davycontrolaltdelete wants to merge 1 commit intomagewirephp:1.xfrom
Conversation
Collaborator
|
Thanks @Davycontrolaltdelete ! really love this and will try to look at it as soon as possible 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
To improve the stability of this open source project, I've create this pull request together @https://github.com/michielgerritsen to add End 2 End tests. The added Github Action does the following:
During testing, the Magewire Examples page is used to check that everything is working as expected. These tests are included:
To install Hyvä in the pipeline we've added a private key to Hyvä's Gitlab so we could install it. To merge this, the
SSH_PRIVATE_KEYsecret must be added, which should be in aid_ed25519format.There is probably more to test, but the main goal was to get some test up & running to be able to expand from that.