Community patch: Braintree PayPal cart button — guard missing clientToken (magento/magento2#40622)#159
Open
Genaker wants to merge 1 commit intomagento:masterfrom
Conversation
Patches vendor/paypal/module-braintree-core view/frontend/web/js/paypal/button.js loadSDK to match express-paypal.js (avoid Braintree INSTANTIATION_OPTION_REQUIRED). Refs: magento/magento2#40622
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 8.1
PHP 8.2
PHP 8.3
PHP 8.4
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-quality-patches/functional build 1195. |
PHP 8.4 B2Bx248Cest OutputThis comment was generated by Jenkins job magento-quality-patches/functional build 1195. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a community quality patch for
paypal/module-braintree-core(PayPal_Braintree):loadSDKinview/frontend/web/js/paypal/button.jsnow returns early whenclientTokenis missing, consistent withexpress-paypal.js, so the Braintree SDK is not called with an emptyauthorization(fixesINSTANTIATION_OPTION_REQUIRED/options.authorization is required when instantiating a client).Magento issue
Patch file
patches/community/magento_magento2_40622_braintree_paypal_button.patchvendor/paypal/module-braintree-core/view/frontend/web/js/paypal/button.js(project root).Package version
Registered for
magento/magento2-base2.4.8 (adjust or extend versions as needed for other lines).Testing
patch -p1 --dry-runapplied cleanly against a 2.4.8 install withpaypal/module-braintree-core4.7.x.