Small cleanup, removed duplicated keys from array

[hostep]

Description (*)

The constants ColumnResolver::COLUMN_WEIGHT and ColumnResolver::COLUMN_WEIGHT_DESTINATION both have the same value 'Weight (and above)'

So adding those both to an array as key makes no sense.

I assume one of both was added at a later point (probably in Magento1 times) and it was forgotten to cleanup the old one.

So that's what I'm doing here. I've left both constants in place just in case somebody does use both of them. But using both in the Magento codebase makes no sense.

It's another effort in trying to get phpstan to run on level 0 on the entire codebase without errors. This only fixes 2 small warnings, but it's a small step forward nonetheless.

Related Pull Requests

• Small cleanup, removed duplicated keys from array magento-coding-standard#495

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

1. Run phpstan analysis:

$ ./vendor/bin/phpstan analyse --level=0 -c dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/phpstan.neon app/code/Magento/ | grep 'duplicate keys'
 14491/14491 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

  26     Array has 2 duplicate keys with value 'Weight (and above)' (\Magento\OfflineShipping\Model\ResourceModel\Carrier\Tablerate\CSV\ColumnResolver::COLUMN_WEIGHT,
  91     Array has 2 duplicate keys with value 'Weight (and above)' (\Magento\OfflineShipping\Model\ResourceModel\Carrier\Tablerate\CSV\ColumnResolver::COLUMN_WEIGHT,

2. Expected is no errors

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Small cleanup, removed duplicated keys from array #39851: Small cleanup, removed duplicated keys from array

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests

[engcom-Hotel]

@magento create issue

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests

[engcom-Charlie]

@magento run Integration Tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Charlie]

✔️ QA Passed

Steps to reproduce

1. Install Magento 2.4 develop
2. Run phpstan analysis:
   ./vendor/bin/phpstan analyse --level=0 -c dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/phpstan.neon app/code/Magento/OfflineShipping/

Before: ❌
Array has 2 duplicate keys with value 'Weight (and above)' error was getting dispalyed

After: ✔️
No error found related to Array has 2 duplicate keys with value 'Weight (and above)'

Moving this PR to Extended Testing to look into the build failures.

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

[engcom-Charlie]

Few of the Functional CE, B2B, EE failures are not consistent. They seems to be flaky, neither part of this PR nor failing because of the PR changes. The rest consistent once are known issues. Hence moving this PR to Merge in Progress.

Functional B2B: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/e2608ac8ccaed341a738d9b0ea24b1ff/Functional/allure-report-b2b/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/4b17e3837c42742fbf4d6201dfdf0782/Functional/allure-report-b2b/index.html#categories/8f0831c1d06562890f5ec21062dae309/1f89ba1be34649ea/

Known Issues:
ACQE-8641: AdminMassOrdersReleasePendingOrderTest
ACQE-8662: AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest
ACQE-8642: AdminCreateOrderWithSimpleProductCustomOptionFileTest
ACQE-8401: AdminCopySingleUpdateToAnotherUpdateTest
ACQE-8636: ViewportSwitcherMobileHTMLThroughBlockContentTypeTest
ACQE-8635: BlockRenderHTMLThroughBlockContentTypeTest
ACQE-8490: AssignCustomOrderStatusNotVisibleOnStorefrontTest
ACQE-8645: StorefrontCreatePurchaseOrderFromNegotiableQuoteTest

Functional CE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/2849c3159b92119b41a5d4fe859f46b6/Functional/allure-report-ce/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/085d161500d051932d80b733d74a5a1e/Functional/allure-report-ce/index.html#categories/8f0831c1d06562890f5ec21062dae309/12530dc993771e42/

Known Issues:
ACQE-8636: ViewportSwitcherMobileHTMLThroughBlockContentTypeTest
ACQE-8635: BlockRenderHTMLThroughBlockContentTypeTest

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/50d74c56a3f185868f5596750d30cda5/Functional/allure-report-ee/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39844/c4a27436229d0371ed68d70a0702ff68/Functional/allure-report-ee/index.html#categories/494aa5610e07373f0a3ae73eacf3dae2/bcf082e8d43e2d48/

Known Issues:
ACQE-8662: AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest
ACQE-8636: ViewportSwitcherMobileHTMLThroughBlockContentTypeTest
ACQE-8490: AssignCustomOrderStatusNotVisibleOnStorefrontTest
ACQE-8655: AdminRmaSettingsConfigurationTest