Respect --basepath configuration option in output#457
Open
fredden wants to merge 6 commits intomagento:developfrom
Open
Respect --basepath configuration option in output#457fredden wants to merge 6 commits intomagento:developfrom
--basepath configuration option in output#457fredden wants to merge 6 commits intomagento:developfrom
Conversation
ihor-sviziev
previously approved these changes
Jul 7, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
ihor-sviziev
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9c2ac84 is the main purpose of this pull request. In order to get there cleanly, a number of refactoring commits were required. I recommend that this pull request is reviewed commit-by-commit, as the final change-set may be confusing.