Upgrade PSR2 -> PSR12 for ControlStructureSpacing#416
Open
fredden wants to merge 8 commits intomagento:developfrom
Open
Upgrade PSR2 -> PSR12 for ControlStructureSpacing#416fredden wants to merge 8 commits intomagento:developfrom
fredden wants to merge 8 commits intomagento:developfrom
Conversation
Member
Author
|
@sidolov what needs to happen to get this merged in? Is there anything I can do to help with that? |
ihor-sviziev
previously approved these changes
Mar 19, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Contributor
|
@magento import PR to magento-commerce/magento-coding-standard repository |
Contributor
|
@sinhaparul the Pull Request is successfully imported. |
Member
|
So, what is blocking this PR? Since
I'd love to advance it before 2024. 🤓 |
Collaborator
|
@sinhaparul @sidolov, is there any reason not to merge this? |
ihor-sviziev
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that this coding standard is using
PSR2.ControlStructures.ControlStructureSpacingandPSR12.ControlStructures.ControlStructureSpacingis also available. From what I can tell, the latter includes checks from the former and some additional useful checks. This pull request changes to use the new version of this sniff.Fixes YouweGit/coding-standard-magento2#6
Related to: #128