Skip to content

Only auto-fix $this to $block when safe to do#413

Open
fredden wants to merge 1 commit intomagento:developfrom
fredden:no-fix-this-helper
Open

Only auto-fix $this to $block when safe to do#413
fredden wants to merge 1 commit intomagento:developfrom
fredden:no-fix-this-helper

Conversation

@fredden
Copy link
Copy Markdown
Member

@fredden fredden commented Jul 7, 2022

Fixes #407

@fredden
Copy link
Copy Markdown
Member Author

fredden commented Oct 14, 2022

@svera is there something I can do to help get this merged in?

@sinhaparul
Copy link
Copy Markdown
Contributor

@magento import PR to magento-commerce/magento-coding-standard repository

@m2-github-services
Copy link
Copy Markdown
Contributor

@sinhaparul the Pull Request is successfully imported.

@brucemead
Copy link
Copy Markdown

Any update on this being available in the stable release of magento/magento-coding-standard? This is preventing production use without a patch 😞

Thanks,
Bruce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacing $this with $block in templates is not universally safe / correct

5 participants