Skip to content

Out of stock label is not working correctly for grouped type product. #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmalevanec wants to merge 6 commits into
base: 1.2.0-develop
Choose a base branch
from
Open

Out of stock label is not working correctly for grouped type product. #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4be3372
Hide sold out grouped product options on grouped PDP.
nmalevanec May 21, 2020
f9ea14e
Fix tests.
nmalevanec May 22, 2020
b6f2be9
Merge branch '1.2.0-develop' into GroupedProductOptionSalabilityFix
nmalevanec Jun 10, 2020
b84f4ba
Add is "show out of stock" verification.
nmalevanec Jun 10, 2020
ad12c9f
Fix tests.
nmalevanec Jun 10, 2020
79ea43c
Fix test.
nmalevanec Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 46 additions & 39 deletions InventoryAdminUi/Test/Mftf/Test/CatalogPriceRuleConfigurableProductAdditionalStockTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,63 +21,70 @@

<before>
<!--Create additional source and stock.-->
<createData entity="_minimalSource" stepKey="additionalSource" after="createProduct"/>
<createData entity="BasicMsiStockWithMainWebsite1" stepKey="additionalStock" after="additionalSource"/>
<createData entity="_minimalSource" stepKey="source" after="createProduct"/>
<createData entity="BasicMsiStockWithMainWebsite1" stepKey="stock" after="source"/>
<!--Link additional source with stock.-->
<createData entity="SourceStockLinked1" stepKey="stockSourceLink" after="additionalStock">
<requiredEntity createDataKey="additionalStock"/>
<requiredEntity createDataKey="additionalSource"/>
<createData entity="SourceStockLinked1" stepKey="stockSourceLink" after="stock">
<requiredEntity createDataKey="stock"/>
<requiredEntity createDataKey="source"/>
</createData>
<!--Replace simple product with configurable.-->
<remove keyForRemoval="createProduct"/>
<createData entity="ConfigurableMsiProduct" stepKey="createProduct"/>
<amOnPage url="{{AdminProductEditPage.url($$createProduct.id$$)}}" stepKey="openConfigurableProductEditPage" after="loginAsAdmin"/>
<click selector="{{AdminProductFormConfigurationsSection.createConfigurations}}" stepKey="clickOnTheCreateConfigurationsButton" after="openConfigurableProductEditPage"/>
<waitForElementVisible selector="{{AdminConfigurableProductSelectAttributesSlideOut.grid}}" time="30" stepKey="waitForGridPresents" after="clickOnTheCreateConfigurationsButton"/>
<click selector="{{AdminGridRow.checkboxByValue('color')}}" stepKey="selectColorAttribute" after="waitForGridPresents"/>
<click selector="{{AdminCreateProductConfigurationsPanel.next}}" stepKey="navigateToSecondStep" after="selectColorAttribute"/>
<click selector="{{AdminCreateProductConfigurationsPanel.createNewValue}}" stepKey="addNewColorWhite" after="navigateToSecondStep"/>
<fillField userInput="{{colorProductAttribute1.name}}" selector="{{AdminCreateProductConfigurationsPanel.attributeName}}" stepKey="setNameWhite" after="addNewColorWhite"/>
<click selector="{{AdminCreateProductConfigurationsPanel.saveAttribute}}" stepKey="saveWhiteColor" after="setNameWhite"/>
<click selector="{{AdminCreateProductConfigurationsPanel.next}}" stepKey="navigateToThirdStep" after="saveWhiteColor"/>
<click selector="{{AdminCreateProductConfigurationsPanel.applySingleQuantityToEachSkus}}" stepKey="clickOnApplySingleQuantityToEachSku" after="navigateToThirdStep"/>
<click selector="{{AdminConfigurableProductAssignSourcesSlideOut.assignSources}}" stepKey="openSelectSourcesModalWindow" after="clickOnApplySingleQuantityToEachSku"/>
<conditionalClick selector="{{AdminDataGridHeaderSection.clearFilters}}" dependentSelector="{{AdminDataGridHeaderSection.clearFilters}}" visible="true" stepKey="clearSourcesFilter" after="openSelectSourcesModalWindow"/>
<actionGroup ref="SearchAdminDataGridByKeywordActionGroup" stepKey="searchCustomSourceByNameForAssignment" after="clearSourcesFilter">
<argument name="keyword" value="$$additionalSource.source[name]$$"/>
<createData entity="ApiConfigurableProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
</createData>
<createData entity="productAttributeWithTwoOptions" stepKey="configurableProductAttribute" after="createProduct"/>
<createData entity="productAttributeOption1" stepKey="configurableProductAttributeOption" after="configurableProductAttribute">
<requiredEntity createDataKey="configurableProductAttribute"/>
</createData>
<createData entity="AddToDefaultSet" stepKey="createConfigAddToAttributeSet" after="configurableProductAttributeOption">
<requiredEntity createDataKey="configurableProductAttribute"/>
</createData>
<getData entity="ProductAttributeOptionGetter" index="1" stepKey="getConfigAttributeOption" after="createConfigAddToAttributeSet">
<requiredEntity createDataKey="configurableProductAttribute"/>
</getData>
<createData entity="ApiSimpleOne" stepKey="configurableChildProduct" after="getConfigAttributeOption">
<requiredEntity createDataKey="configurableProductAttribute"/>
<requiredEntity createDataKey="getConfigAttributeOption"/>
</createData>
<createData entity="ConfigurableProductOneOption" stepKey="configurableProductOption" after="configurableChildProduct">
<requiredEntity createDataKey="createProduct"/>
<requiredEntity createDataKey="configurableProductAttribute"/>
<requiredEntity createDataKey="getConfigAttributeOption"/>
</createData>
<createData entity="ConfigurableProductAddChild" stepKey="configurableProductAddChild" after="configurableProductOption">
<requiredEntity createDataKey="createProduct"/>
<requiredEntity createDataKey="configurableChildProduct"/>
</createData>
<!--Assign additional source to configurable product.-->
<amOnPage url="{{AdminProductEditPage.url($configurableChildProduct.id$)}}" stepKey="openProductEditPage" after="loginAsAdmin"/>
<actionGroup ref="UnassignSourceFromProductActionGroup" stepKey="unassignDefaultSourceFromProduct" after="openProductEditPage">
<argument name="sourceCode" value="{{_defaultSource.name}}"/>
</actionGroup>
<click selector="{{AdminGridRow.checkboxByValue($$additionalSource.source[name]$$)}}" stepKey="selectCustomSource" after="searchCustomSourceByNameForAssignment"/>
<click selector="{{AdminConfigurableProductAssignSourcesSlideOut.done}}" stepKey="daneAssignSources" after="selectCustomSource"/>
<fillField selector="{{AdminConfigurableProductAssignSourcesSlideOut.quantityPerSourceForMultiMode}}" userInput="100" stepKey="fillQuantityForCustomSource" after="daneAssignSources"/>
<click selector="{{AdminCreateProductConfigurationsPanel.next}}" stepKey="navigateToFourthStep" after="fillQuantityForCustomSource"/>
<click selector="{{AdminCreateProductConfigurationsPanel.next}}" stepKey="doneGeneratingConfigurableVariations" after="navigateToFourthStep"/>
<click selector="{{AdminProductFormSection.save}}" stepKey="saveConfigurableProduct" after="doneGeneratingConfigurableVariations"/>
<conditionalClick selector="{{AdminChooseAffectedAttributeSetPopup.confirm}}" dependentSelector="{{AdminChooseAffectedAttributeSetPopup.confirm}}" visible="true" stepKey="confirmDefaultAttributeSetForConfigurableProduct" after="saveConfigurableProduct"/>
<!--Set configurable product stock status.-->
<selectOption selector="{{AdminProductFormSection.productStockStatus}}" userInput="In Stock" stepKey="setProductStockStatus" after="confirmDefaultAttributeSetForConfigurableProduct"/>
<!--Assign configurable product to category.-->
<actionGroup ref="AdminAssignCategoryToProductAndSaveActionGroup" stepKey="assignCategoryToConfigurableProduct" after="setProductStockStatus">
<argument name="categoryName" value="$$createCategory.name$$"/>
<actionGroup ref="AdminAssignSourceToProductAndSetSourceQuantityActionGroup" stepKey="assignSourceToProduct" after="unassignDefaultSourceFromProduct">
<argument name="sourceCode" value="$source.source[source_code]$"/>
</actionGroup>
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct" after="assignSourceToProduct"/>
</before>
<after>
<!--Clean up test data.-->
<deleteData createDataKey="configurableChildProduct" stepKey="deleteConfigurableProductVariation" after="deleteCategory"/>
<deleteData createDataKey="configurableProductAttribute" stepKey="deleteConfigurableProductAttribute" after="deleteConfigurableProductVariation"/>
<!--Assign Default Stock to Default Website.-->
<actionGroup ref="AssignWebsiteToStockActionGroup" stepKey="assignMainWebsiteToDefaultStock" after="deleteCategory">
<actionGroup ref="AssignWebsiteToStockActionGroup" stepKey="assignMainWebsiteToDefaultStock" after="deleteConfigurableProductAttribute">
<argument name="stockName" value="{{_defaultStock.name}}"/>
<argument name="websiteName" value="{{_defaultWebsite.name}}"/>
</actionGroup>
<!--Disable additional source.-->
<actionGroup ref="DisableSourceActionGroup" stepKey="disableCreatedSource" before="assignMainWebsiteToDefaultStock">
<argument name="sourceCode" value="$$additionalSource.source[source_code]$$"/>
</actionGroup>
<actionGroup ref="DisableAllSourcesActionGroup" stepKey="disableCreatedSource" before="assignMainWebsiteToDefaultStock"/>
<!--Delete stock.-->
<deleteData createDataKey="additionalStock" stepKey="deleteStock" after="assignMainWebsiteToDefaultStock"/>
<deleteData createDataKey="stock" stepKey="deleteStock" after="assignMainWebsiteToDefaultStock"/>
</after>

<!--Verify configurable product prices.-->
<remove keyForRemoval="seeDiscountedPrice1"/>
<see selector="{{StorefrontCategoryProductSection.ProductInfoByNumber('1')}}" userInput="As low as $90.00" stepKey="seeDiscountedPrice1" after="seeProduct1"/>
<see selector="{{StorefrontCategoryProductSection.ProductInfoByNumber('1')}}" userInput="As low as $110.70" stepKey="seeDiscountedPrice1" after="seeProduct1"/>
<remove keyForRemoval="seeDiscountedPrice2"/>
<see selector="{{StorefrontCategoryProductSection.ProductInfoByNumber('1')}}" userInput="As low as $100.00" stepKey="seeDiscountedPrice2" after="seeProduct2"/>
<see selector="{{StorefrontCategoryProductSection.ProductInfoByNumber('1')}}" userInput="As low as ${{ApiSimpleOne.price}}" stepKey="seeDiscountedPrice2" after="seeProduct2"/>
</test>
</tests>
116 changes: 116 additions & 0 deletions ...oryAdminUi/Test/Mftf/Test/StorefrontGroupedProductCustomStockWithOneOptionSoldOutTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="StorefrontGroupedProductCustomStockWithOneOptionSoldOutTest">
<annotations>
<stories value="Grouped Product Custom Stock."/>
<title value="Grouped product option salability on custom stock."/>
<description value="Verify totally sold out grouped product option on custom stock is not visible on storefront."/>
<testCaseId value="https://studio.cucumber.io/projects/69435/test-plan/folders/912250/scenarios/4747577"/>
<severity value="CRITICAL"/>
<group value="msi"/>
<group value="multi_mode"/>
</annotations>

<before>
<!--Create test data.-->
<createData entity="FullSource1" stepKey="source"/>
<createData entity="BasicMsiStockWithMainWebsite1" stepKey="stock"/>
<createData entity="SourceStockLinked1" stepKey="linkSourceStock">
<requiredEntity createDataKey="stock"/>
<requiredEntity createDataKey="source"/>
</createData>
<createData entity="ApiGroupedProduct" stepKey="groupedProduct"/>
<createData entity="ApiProductWithDescription" stepKey="product1"/>
<createData entity="ApiProductWithDescription" stepKey="product2"/>
<createData entity="OneSimpleProductLink" stepKey="addProductOne">
<requiredEntity createDataKey="groupedProduct"/>
<requiredEntity createDataKey="product1"/>
</createData>
<updateData entity="OneMoreSimpleProductLink" createDataKey="addProductOne" stepKey="addProductTwo">
<requiredEntity createDataKey="groupedProduct"/>
<requiredEntity createDataKey="product2"/>
</updateData>
<createData entity="MsiCustomer1" stepKey="customer"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
<!--Assign sources to product1.-->
<actionGroup ref="NavigateToCreatedProductEditPageActionGroup" stepKey="navigateToSimpleProduct1">
<argument name="product" value="$product1$"/>
</actionGroup>
<actionGroup ref="UnassignSourceFromProductActionGroup" stepKey="unassignDefaultSourceFromProduct1">
<argument name="sourceCode" value="{{_defaultSource.name}}"/>
</actionGroup>
<actionGroup ref="AdminAssignSourceToProductAndSetSourceQuantityActionGroup" stepKey="assignSourceToProduct1">
<argument name="sourceCode" value="$source.source[source_code]$"/>
<argument name="sourceQty" value="{{minimalProductQty.value}}"/>
</actionGroup>
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct1"/>
<!--Assign sources to product2.-->
<actionGroup ref="NavigateToCreatedProductEditPageActionGroup" stepKey="navigateToSimpleProduct2">
<argument name="product" value="$product2$"/>
</actionGroup>
<actionGroup ref="UnassignSourceFromProductActionGroup" stepKey="unassignDefaultSourceFromProduct2">
<argument name="sourceCode" value="{{_defaultSource.name}}"/>
</actionGroup>
<actionGroup ref="AdminAssignSourceToProductAndSetSourceQuantityActionGroup" stepKey="assignSourceToProduct2">
<argument name="sourceCode" value="$source.source[source_code]$"/>
</actionGroup>
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct2"/>
</before>
<after>
<deleteData createDataKey="customer" stepKey="deleteCustomer"/>
<deleteData createDataKey="groupedProduct" stepKey="deleteGroupedProduct"/>
<deleteData createDataKey="product1" stepKey="deleteSimpleProduct1"/>
<deleteData createDataKey="product2" stepKey="deleteSimpleProduct2"/>
<!--Assign Default Stock to Default Website.-->
<actionGroup ref="AssignWebsiteToStockActionGroup" stepKey="assignMainWebsiteToDefaultStock">
<argument name="stockName" value="{{_defaultStock.name}}"/>
<argument name="websiteName" value="{{_defaultWebsite.name}}"/>
</actionGroup>
<!--Disable created sources.-->
<actionGroup ref="DisableAllSourcesActionGroup" stepKey="disableSource"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutOfAdmin"/>
<deleteData createDataKey="stock" stepKey="deleteStock"/>
</after>

<!--Login To storefront as Customer-->
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginToStorefront">
<argument name="Customer" value="$$customer$$"/>
</actionGroup>
<!--Add grouped product to cart.-->
<actionGroup ref="StorefrontOpenProductEntityPageActionGroup" stepKey="navigateToGroupedProductPDP">
<argument name="product" value="$groupedProduct$"/>
</actionGroup>
<actionGroup ref="StorefrontAddGroupedProductWithTwoLinksToCartActionGroup" stepKey="addGroupedProductToCart">
<argument name="product" value="$groupedProduct$"/>
<argument name="linkedProduct1Name" value="$product1.name$"/>
<argument name="linkedProduct2Name" value="$product2.name$"/>
</actionGroup>
<!--Place order.-->
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="navigateToCheckoutPage"/>
<click selector="{{CheckoutShippingSection.next}}" stepKey="clickNextButton"/>
<actionGroup ref="ClickPlaceOrderActionGroup" stepKey="clickOnPlaceOrder"/>
<grabTextFrom selector="{{CheckoutSuccessMainSection.orderNumber22}}" stepKey="orderNumber"/>
<!--Create Shipment-->
<actionGroup ref="OpenOrderByIdActionGroup" stepKey="openOrder">
<argument name="orderId" value="{$orderNumber}"/>
</actionGroup>
<actionGroup ref="AdminShipThePendingOrderActionGroup" stepKey="shipOrder"/>
<!--Verify grouped product PDP.-->
<actionGroup ref="StorefrontOpenProductEntityPageActionGroup" stepKey="navigateToGroupedProductPDPAfterOrderPlacement">
<argument name="product" value="$groupedProduct$"/>
</actionGroup>
<actionGroup ref="StorefrontAssertLinkIsNotVisibleOnGroupedProductPageActionGroup" stepKey="verifyFirstOptionIsNotPresentedOnPage">
<argument name="productName" value="$product1.name$"/>
</actionGroup>
<actionGroup ref="AssertLinkPresenceOnGroupedProductPage" stepKey="verifySecondOptionIsStillPresentedOnPage">
<argument name="productName" value="$product2.name$"/>
</actionGroup>
</test>
</tests>
Loading