chore(goreleaser): fix release asset names#547
Merged
natefinch merged 6 commits intomagefile:masterfrom Mar 31, 2026
Merged
Conversation
2 tasks
natefinch
previously approved these changes
Mar 28, 2026
Member
natefinch
left a comment
There was a problem hiding this comment.
Thank you! I added a test so that it doesn't get broken again.
1 task
|
@natefinch are you planning to get a 1.18.0 release out after that? |
Member
|
@chantra sorry for the delay, the tests were kind of a headache to fix, but I didn't want this to go in without proper tests so that they won't break again. I just released v1.17.1 with the fixed asset names |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #548
Asset names of v1.17.0 are broken.
https://github.com/magefile/mage/releases/tag/v1.17.0
gh release view --json assets --jq ".assets[].name" -R magefile/mage v1.17.0This is due to the recent change of .gorelaeser.yml.
This PR fixes asset names.
Test
I ran
goreleaser releaseand released assets to my fork.https://github.com/suzuki-shunsuke/mage/releases/tag/v1.17.1
gh release view --json assets --jq ".assets[].name" -R suzuki-shunsuke/mage v1.17.1The naming style is same with v1.16.0.
gh release view --json assets --jq ".assets[].name" -R magefile/mage v1.16.0