Skip to content

Removed ext-ftp dependency and deprecated the class related to the FTP#190

Merged
rhoerr merged 8 commits intomage-os:release/3.xfrom
konarshankar07:removed-ext-ftp-extension-dependency
Apr 24, 2026
Merged

Removed ext-ftp dependency and deprecated the class related to the FTP#190
rhoerr merged 8 commits intomage-os:release/3.xfrom
konarshankar07:removed-ext-ftp-extension-dependency

Conversation

@konarshankar07
Copy link
Copy Markdown
Contributor

Description (*)

This PR will remove the ext-ftp dependency from the mage-os and also marked the class related to the FTP depecated

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes mage-os/mageos-magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@konarshankar07 konarshankar07 requested a review from a team as a code owner December 14, 2025 19:14
konarshankar07 and others added 6 commits December 15, 2025 00:52
Disable backup functionality by returning false in isEnabled method.
Removed backup execution logic and related error handling.
Remove unnecessary blank line in FTP client documentation.
rhoerr
rhoerr previously approved these changes Apr 5, 2026
Copy link
Copy Markdown
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @konarshankar07. I made some additional changes to totally hide and disable the Magento_Backup module functionality. I opted to disable in-place rather than remove entirely to minimize future merge conflicts.

@rhoerr rhoerr changed the base branch from main to release/3.x April 5, 2026 22:02
@rhoerr rhoerr added the enhancement New feature or request label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @konarshankar07

@rhoerr rhoerr merged commit bb7a972 into mage-os:release/3.x Apr 24, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants