Skip to content

File format validation #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppeczek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

File format validation #115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e3f706
File format validation
ppeczek Jun 15, 2016
5029592
Hotfix for format validation
ppeczek Jun 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ Playback-win32.zip
Playback.app
Playback.app.zip
.DS_Store
.idea
6 changes: 6 additions & 0 deletions playlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ var concat = require('concat-stream')

var noop = function () {}

var allowedExts = ["mpg", "mkv", "mp4", "mp3", "vtt", "srt"]

@freeall freeall Jun 15, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ' instead of "


module.exports = function () {
var that = new events.EventEmitter()

Expand Down Expand Up @@ -141,6 +143,10 @@ module.exports = function () {

file.length = st.size
file.name = path.basename(link)
var filenameArr = file.name.split(".")
file.extension = filenameArr[filenameArr.length-1].toLowerCase()

@freeall freeall Jun 15, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do file.name.split('.').pop() for the last one

if (allowedExts.indexOf(file.extension) == -1) return cb("File format not supported")

@freeall freeall Jun 15, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the strict equality check, === instead of ==


file.createReadStream = function (opts) {
return fs.createReadStream(link, opts)
}
Expand Down