Treat the app extension as the default local provider - #111
Merged
Conversation
Local Debug/Release already ship PlugIns/TransparentProxy.appex. Docs and deploy scripts now match that: require the appex, prune the Developer ID system-extension product so the two providers cannot share a bundle ID at runtime, start via the autoconnect sentinel (scutil --nc races before the NE config exists), and wait for "meow engine started" instead of the old tun2socks packet_thread marker. Developer ID PKG/DMG still ship the system-extension variant (TN3134). Also keep bridge_version in lockstep with the pinned meow-rs 0.21.1 workspace version, and drop the SIP-off / systemextensionsctl E2E path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of the unique leftovers from closed #103 (that PR could not merge: it would have regressed #105–#109).
bridge_versionin lockstep with the pinned meow-rs 0.21.1 workspace version.PlugIns/TransparentProxy.appex, prune the Developer ID system-extension product so the two providers cannot share a bundle ID at runtime, start via the autoconnect sentinel, and wait formeow engine started(the Go-erapacket_threadmarker never fires on meow-rs).systemextensionsctl/ recovery-mode SIP disable, require the appex instead.Not in this PR (intentionally left on
main): meow-rs 0.21.1 pin, per-subscriptionProxyGroupSelections, hermetic SOCKS5 tests, controller-secret TrafficStore tests.Test plan
cargo fmt --all -- --check && cargo clippy --all-targets -- -D warnings && cargo test --libinRust/meow-ffi(23 passed)swiftlint lint --strict(0 violations)xcodebuild test … -only-testing:BaoLianDengTests(220 passed)make framework+ Debug/Release app build