Skip to content

feat: add contextual command palette - #337

Closed
salmonumbrella wants to merge 2 commits into
maathimself:mainfrom
salmonumbrella:feat/contextual-command-k
Closed

feat: add contextual command palette#337
salmonumbrella wants to merge 2 commits into
maathimself:mainfrom
salmonumbrella:feat/contextual-command-k

Conversation

@salmonumbrella

Copy link
Copy Markdown
Contributor

Summary

Adds the authenticated desktop Command-K experience on the shared command engine, with contextual application commands, accessible keyboard operation, and a MailFlow-native visual shell.

Review the last commit only; #335 is the prerequisite.

Closes #336.

Changes

  • share checkbox selection through Zustand and build immutable live command contexts
  • register Compose, Search, Contacts, inbox/account/folder/GTD, theme, and applicable Settings commands
  • compose one registry/controller runtime with continuation and terminal-outcome handling
  • rebuild the palette with localized fuzzy results, alias explanations, target disclosure, semantic icons, and right-aligned shortcut hints
  • preserve the exact 5.5-row viewport while scrolling the active keyboard option into view
  • trap and restore focus, expose complete dialog/listbox/active-descendant semantics, and ignore navigation/execution during IME composition
  • preserve rich-editor Insert Link on the first Cmd/Ctrl+K and open the palette on the second press
  • localize the complete command and palette surface across all seven supported locales
  • add no dependency; filtering and ranking remain registry-owned

Testing

  • cd frontend && npm test (1,634 passed)
  • cd frontend && npm run lint (zero warnings)
  • cd frontend && npm run build (passed; existing chunk-size advisory only)
  • authenticated browser acceptance for the exact 286px / 52px = 5.5-row viewport, keyboard scrolling, alias disclosure, focus trap/restoration, ARIA state, and dark/light theme integration
  • git diff --check f226af6..HEAD
  • verified exactly one PR-specific commit and no dependency manifests, plans, credentials, local paths, or PII

Contributor License Agreement

By submitting this pull request I confirm that:

  • I have read and agree to the Contributor License Agreement.
  • My contribution is my own original work (or I have identified any
    third-party material and confirmed it is compatible with the CLA).
  • I have the right to submit this contribution under the terms of the CLA.

@salmonumbrella
salmonumbrella force-pushed the feat/contextual-command-k branch from 2058960 to 16b0864 Compare August 1, 2026 02:51
@maathimself maathimself closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebuild Command-K on the shared command engine

2 participants