Skip to content

fix: correct CaptureIntegrationSpecificIds.V2 feature flag string #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmi22186 merged 3 commits into from
Apr 16, 2026
Merged

fix: correct CaptureIntegrationSpecificIds.V2 feature flag string #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26f58ae
fix: correct CaptureIntegrationSpecificIdsV2 feature flag key to matc…
rmi22186 Apr 16, 2026
bc1f166
test: use actual server key for captureIntegrationSpecificIds.V2 in t…
rmi22186 Apr 16, 2026
cb60633
refactor: update IFeatureFlags interface to use actual server key
rmi22186 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ const Constants = {
// - 'all' → capture all IDs
// - 'none' → capture none
// - 'roktonly' → capture only Rokt-related IDs
CaptureIntegrationSpecificIdsV2: 'captureIntegrationSpecificIdsV2',
CaptureIntegrationSpecificIdsV2: 'captureIntegrationSpecificIds.V2',
Comment thread
cursor[bot] marked this conversation as resolved.
AstBackgroundEvents: 'astBackgroundEvents',
},
DefaultInstance: 'default_instance',
Expand Down
2 changes: 1 addition & 1 deletion src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export interface IFeatureFlags {
directURLRouting?: boolean;
cacheIdentity?: boolean;
captureIntegrationSpecificIds?: boolean;
captureIntegrationSpecificIdsV2?: string;
'captureIntegrationSpecificIds.V2'?: string;
astBackgroundEvents?: boolean;
}

Expand Down
2 changes: 1 addition & 1 deletion test/src/tests-batchUploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ describe('batch uploader', () => {
};

window.mParticle.config.flags.captureIntegrationSpecificIds = "False";
window.mParticle.config.flags.captureIntegrationSpecificIdsV2 = "roktonly";
window.mParticle.config.flags['captureIntegrationSpecificIds.V2'] = "roktonly";

const consentState = window.mParticle.Consent.createConsentState();
const timestamp = new Date().getTime();
Expand Down
4 changes: 2 additions & 2 deletions test/src/tests-feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe('feature-flags', () => {
it('should capture click ids when feature flag is true', async () => {
window.mParticle.config.flags = {
captureIntegrationSpecificIds: 'True',
captureIntegrationSpecificIdsV2: 'all'
'captureIntegrationSpecificIds.V2': 'all'
};

// initialize mParticle with feature flag
Expand Down Expand Up @@ -149,7 +149,7 @@ describe('feature-flags', () => {
it('should NOT capture click ids when feature flag is false', async () => {
window.mParticle.config.flags = {
captureIntegrationSpecificIds: 'False',
captureIntegrationSpecificIdsV2: 'none'
'captureIntegrationSpecificIds.V2': 'none'
};

// initialize mParticle with feature flag
Expand Down
2 changes: 1 addition & 1 deletion test/src/tests-integration-capture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Integration Capture', () => {

window.mParticle.config.flags = {
captureIntegrationSpecificIds: 'True',
captureIntegrationSpecificIdsV2: 'all'
'captureIntegrationSpecificIds.V2': 'all'
};

window.document.cookie = '_cookie1=234';
Expand Down
10 changes: 5 additions & 5 deletions test/src/tests-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,7 @@ describe('Store', () => {
cacheIdentity: 'False',
audienceAPI: 'False',
captureIntegrationSpecificIds: 'False',
captureIntegrationSpecificIdsV2: 'none',
'captureIntegrationSpecificIds.V2': 'none',
astBackgroundEvents: 'True',
},
};
Expand All @@ -1399,7 +1399,7 @@ describe('Store', () => {
cacheIdentity: false,
audienceAPI: false,
captureIntegrationSpecificIds: false,
captureIntegrationSpecificIdsV2: 'none',
'captureIntegrationSpecificIds.V2': 'none',
astBackgroundEvents: true,
};

Expand Down Expand Up @@ -1599,7 +1599,7 @@ describe('Store', () => {
cacheIdentity: false,
audienceAPI: false,
captureIntegrationSpecificIds: false,
captureIntegrationSpecificIdsV2: 'none',
'captureIntegrationSpecificIds.V2': 'none',
astBackgroundEvents: false,
};

Expand All @@ -1615,7 +1615,7 @@ describe('Store', () => {
cacheIdentity: 'True',
audienceAPI: 'True',
captureIntegrationSpecificIds: 'True',
captureIntegrationSpecificIdsV2: 'all',
'captureIntegrationSpecificIds.V2': 'all',
astBackgroundEvents: 'True',
};

Expand All @@ -1631,7 +1631,7 @@ describe('Store', () => {
cacheIdentity: true,
audienceAPI: true,
captureIntegrationSpecificIds: true,
captureIntegrationSpecificIdsV2: 'all',
'captureIntegrationSpecificIds.V2': 'all',
astBackgroundEvents: true,
};

Expand Down
Loading