Repository navigation
fix(rest): pin the toolchain that generates the embedded spec - #4
Merged
Merged
Conversation
oapi-codegen embeds the OpenAPI spec as a base64'd compress/flate stream, so the bytes of ports/rest/v1/gen.go depend on the stdlib's deflate implementation. Regenerating on a newer Go than CI's produces a byte-different file, and the quality workflow's generated-code drift gate fails on a commit that changed nothing but the spec. Pin GOTOOLCHAIN for the generate recipes to the toolchain go.mod already names -- the same one setup-go installs -- so `make generate` is reproducible regardless of the Go on the developer's PATH, and regenerate gen.go under that pin. Only the embedded blob changes. Assisted-by: Claude:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oapi-codegen embeds the OpenAPI spec as a base64'd compress/flate stream, so the bytes of ports/rest/v1/gen.go depend on the stdlib's deflate implementation. Regenerating on a newer Go than CI's produces a byte-different file, and the quality workflow's generated-code drift gate fails on a commit that changed nothing but the spec.
Pin GOTOOLCHAIN for the generate recipes to the toolchain go.mod already names -- the same one setup-go installs -- so
make generateis reproducible regardless of the Go on the developer's PATH, and regenerate gen.go under that pin. Only the embedded blob changes.Assisted-by: Claude:claude-opus-5