Repository navigation
chore(ci): wire lint into CI, fix cross-caller concurrency collision - #2
Merged
Merged
Conversation
lint.yml is now also called from ci.yml (not just quality.yml), so a formatting/lint break shows up on the same run as the build. lint.yml's concurrency group was keyed only on github.ref, so ci.yml and quality.yml's simultaneous lint calls on the same PR shared a group and cancelled each other. Added a required `caller` input, threaded through by each caller, and folded into the group key. Assisted-by: Claude:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lint.ymlis now also called fromci.yml(in addition toquality.yml), so a formatting/lint break shows on the same run as the build.lint.yml's concurrency group was keyed only ongithub.ref. With two callers now hitting it on the same PR simultaneously, they shared a group and cancelled each other's lint run. Fixed by adding a requiredcallerinput, threaded from each caller, folded into the group key.Why
CI feedback on lint issues previously only showed up via the separate
qualityworkflow; wiring it intocisurfaces it alongside build/test on the same check run.