[subcluster-validation] Allow a shard to span a subcluster being drained - #4397
Open
prateek2211 wants to merge 1 commit into
Open
[subcluster-validation] Allow a shard to span a subcluster being drained#4397prateek2211 wants to merge 1 commit into
prateek2211 wants to merge 1 commit into
Conversation
…being drained Draining a node of a subclustered placement one batch of shards at a time leaves its subcluster holding fewer replicas than its share of the placement, and the shards moved out of it are shared with another subcluster until the drain finishes. Validation rejected that state as long as both subclusters still held their full set of instances, so a node could only be drained in a single step. A shard may now span two subclusters when either of them is incomplete, that is when it is missing instances or when it holds fewer replicas than its target shard count times the replication factor. A shard shared by two complete subclusters is still rejected. Co-authored-by: Cursor <cursoragent@cursor.com>
|
prateek.sachan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Draining a node of a subclustered placement one batch of shards at a time leaves its subcluster holding fewer replicas than its share of the placement, and the shards moved out of it are shared with another subcluster until the drain finishes. Validation rejected that state as long as both subclusters still held their full set of instances, so a node could only be drained in a single step.
A shard may now span two subclusters when either of them is incomplete, that is when it is missing instances or when it holds fewer replicas than its target shard count times the replication factor. A shard shared by two complete subclusters is still rejected.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: