Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional OpenTelemetry (OTel) tracing instrumentation across core execution paths (ability building, runtime filter application, and GraphQL execution) to improve observability in rumble.
Changes:
- Introduces OTel + Pothos tracing dependencies and adds
otelconfiguration toRumbleInput. - Wires tracing into schema building (Pothos tracing plugin + OTel wrapper) and GraphQL Yoga execution.
- Instruments ability filter assembly and runtime filter application with spans + attributes.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds OTel + Pothos tracing dependencies. |
| bun.lock | Locks new dependencies (OTel + tracing packages) and updates Svelte patch version. |
| lib/types/rumbleInput.ts | Extends RumbleInput with an optional otel config (tracer + wrapper options). |
| lib/schemaBuilder.ts | Registers Pothos tracing plugin and configures wrapping via OTel tracer. |
| lib/runtimeFiltersPlugin/runtimeFiltersPlugin.ts | Wraps filter application in spans and records basic filter metrics. |
| lib/runtimeFiltersPlugin/pluginTypes.d.ts | Extends Pothos builder options to carry an otelTracer. |
| lib/rumble.ts | Adds Yoga onExecute span around GraphQL execution and records operation metadata. |
| lib/abilityBuilder.ts | Adds span-based instrumentation for ability filter preparation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds OpenTelemetry tracing support throughout the codebase, enabling detailed instrumentation for ability building, filter application, and GraphQL execution. The changes introduce new dependencies, update configuration types, and integrate tracing into core logic for enhanced observability.
Tracing integration:
createAbilityBuilder, instrumenting ability filter logic and recording span attributes for unrestricted, blocked, dynamic, and applied abilities. (lib/abilityBuilder.ts) [1] [2] [3] [4] [5]RuntimeFiltersPluginto record filter status, total filters, and allowed entities, and to wrap filter application in spans. (lib/runtimeFiltersPlugin/runtimeFiltersPlugin.ts) [1] [2] [3]lib/rumble.ts) [1] [2]Schema builder enhancements:
createSchemaBuilder, including span wrapper setup and root field detection. (lib/schemaBuilder.ts) [1] [2] [3] [4]Configuration and dependencies:
RumbleInputtype to support tracing configuration and options, and updated dependencies to include OpenTelemetry and Pothos tracing packages. (lib/types/rumbleInput.ts,package.json) [1] [2] [3]