Skip to content
This repository was archived by the owner on Jan 18, 2026. It is now read-only.

update interval,timestamp to dashboard on checkbox - #2922

Open
hubuke wants to merge 3 commits into
m-labs:masterfrom
hubuke:add_uniform_interval_to_dashboard
Open

update interval,timestamp to dashboard on checkbox#2922
hubuke wants to merge 3 commits into
m-labs:masterfrom
hubuke:add_uniform_interval_to_dashboard

Conversation

@hubuke

@hubuke hubuke commented Dec 9, 2025

Copy link
Copy Markdown

Add uniform_interval option to artiq dashboard
When checked, "Add channels" dialogue box would have timestamp and interval trace. These two trace can be added to the waveform viewer.

@hubuke

hubuke commented Dec 9, 2025

Copy link
Copy Markdown
Author

I think it is also worth it to add an auto zoom/zoom fit button. With uniform_interval, step is 1 ps on waveform viewer. Very hard to access. Any suggestion/idea?

@SimonRenblad

Copy link
Copy Markdown
Contributor

I think it is also worth it to add an auto zoom/zoom fit button. With uniform_interval, step is 1 ps on waveform viewer. Very hard to access. Any suggestion/idea?

IIRC I already implemented this with the Reset zoom button?

@SimonRenblad

Copy link
Copy Markdown
Contributor

step is 1 ps on waveform viewer

The unit in the x axis should also be hidden with uniform_interval on.

@hubuke

hubuke commented Dec 9, 2025

Copy link
Copy Markdown
Author

May be I understand reset zoom incorrectly, I'll double check

@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from c4193c2 to 8307d1e Compare December 10, 2025 09:21
@hubuke

hubuke commented Dec 10, 2025

Copy link
Copy Markdown
Author

Separate PRs. This PR #2922 for uniform_interval support.
PR #2926 for fixing reset zoom button.

@hubuke
hubuke marked this pull request as draft December 11, 2025 07:11
@hubuke

hubuke commented Dec 12, 2025

Copy link
Copy Markdown
Author
  1. add feature to update waveform data to uniform_interval mode without re-fetch. If timestamp and interval trace added to the viewer, it won't disappear on uniform_interval toggle. This is intended since it's easy to manually remove and maybe save the clicks to add it back from add trace dialogue box.
  2. For top ref axis, I think we should keep the tick numbers since it provides a nice counter for events. But update axis label to "uniform interval (1ps/action)". Maybe need a better name?

@hubuke
hubuke marked this pull request as ready for review December 12, 2025 09:23
@SimonRenblad

Copy link
Copy Markdown
Contributor

But update axis label to "uniform interval (1ps/action)". Maybe need a better name?

If possible we would want to avoid any reference to ps there. It would be confusing since the x-axis is really changed to units of "interval" / no unit.

@hubuke

hubuke commented Dec 12, 2025

Copy link
Copy Markdown
Author

unit="tick"?

Comment thread artiq/dashboard/waveform.py Outdated
@SimonRenblad

Copy link
Copy Markdown
Contributor

unit="tick"?

Better, but may be confused with CPU ticks I guess.

@hubuke hubuke mentioned this pull request Dec 16, 2025
@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from 5f3af50 to c9ed32b Compare December 18, 2025 07:27
@hubuke
hubuke requested a review from SimonRenblad December 30, 2025 05:49
@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from 16523d8 to e4fcf0a Compare December 31, 2025 09:17
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from d61e5de to c43928f Compare January 5, 2026 08:08
@hubuke
hubuke requested a review from SimonRenblad January 5, 2026 08:22
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
Comment thread artiq/dashboard/waveform.py Outdated
@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from b3396ff to e65b238 Compare January 6, 2026 03:21
@hubuke
hubuke requested a review from SimonRenblad January 6, 2026 03:34
@hubuke
hubuke force-pushed the add_uniform_interval_to_dashboard branch from e65b238 to 605c0de Compare January 6, 2026 03:40
@sbourdeauducq

Copy link
Copy Markdown
Member

Needs update of release notes.

Comment thread RELEASE_NOTES.rst Outdated
Comment thread RELEASE_NOTES.rst Outdated
- State files are now automatically backed up upon successful loading.
- Experiments can now use ``restart_applet`` CCB command to restart applets.
- Interactive argument widgets now remember their layout between runs.
- Waveform Viewer now supports the ``uniform_interval`` option, equivalent to the ``-u`` option

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uniform_interval option"?
In a GUI?

Comment thread artiq/dashboard/waveform.py Outdated

def _setValueFromText(self, text):
try:
if not text.strip().endswith(("event", "events", "s")):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fishy to me. Isn't there a better way of doing this?

Comment thread RELEASE_NOTES.rst Outdated
@hubuke
hubuke requested a review from sbourdeauducq January 6, 2026 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants