internal/tags: remove deprecated rand.Seed call in test - #188
Merged
Conversation
rand.Seed has been deprecated since Go 1.20 (staticcheck SA1019): the global math/rand source is auto-seeded since then, so calling Seed with a time-based value is a no-op. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sokada1221
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rand.Seedhas been deprecated since Go 1.20 (flagged by staticcheck SA1019 in CI on the zero-alloc-tags stack): the globalmath/randsource auto-seeds since then, so this call is a no-op.Test plan
go build ./...,go vet ./...cleango test ./internal/tags/...passing🤖 Generated with Claude Code