internal/tags: add HashTags/TagSet.Hash for zero-alloc tag hashing - #187
Draft
th0114nd wants to merge 1 commit into
Draft
internal/tags: add HashTags/TagSet.Hash for zero-alloc tag hashing#187th0114nd wants to merge 1 commit into
th0114nd wants to merge 1 commit into
Conversation
Adds HashTags(name, tags) and TagSet.Hash(name), which compute a 128-bit hash of the same canonical serialized form SerializeTags/ TagSet.Serialize produce, without ever materializing that string. Reuses the gatherValidTags/numValidTags helpers and stack-tier sizing introduced for SerializeTags: pairs are gathered into a small stack array (or a single exact-size heap allocation past 16 tags) and sorted via TagSet.Sort(), then the serialized name+tags bytes are built into a similarly-tiered stack buffer (128/256/512 bytes, heap beyond that) and hashed directly, without ever needing a heap allocation for the common case. This is intended to back a hash-keyed sync.Map lookup for counters/ gauges, so that repeat calls to NewCounterWithTags et al. (cache hits) no longer allocate on every call the way building the serialized string today does. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds HashTags(name, tags) and TagSet.Hash(name), which compute a
128-bit hash of the same canonical serialized form SerializeTags/
TagSet.Serialize produce, without ever materializing that string.
Reuses the gatherValidTags/numValidTags helpers and stack-tier
sizing introduced for SerializeTags: pairs are gathered into a small
stack array (or a single exact-size heap allocation past 16 tags)
and sorted via TagSet.Sort(), then the serialized name+tags bytes
are built into a similarly-tiered stack buffer (128/256/512 bytes,
heap beyond that) and hashed directly, without ever needing a heap
allocation for the common case.
This is intended to back a hash-keyed sync.Map lookup for counters/
gauges, so that repeat calls to NewCounterWithTags et al. (cache
hits) no longer allocate on every call the way building the
serialized string today does.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬