Skip to content

internal/tags: route SerializeTags through TagSet - #186

Draft
th0114nd wants to merge 1 commit into
zero-alloc-tags-01-sortingfrom
zero-alloc-tags-02-serialize
Draft

internal/tags: route SerializeTags through TagSet#186
th0114nd wants to merge 1 commit into
zero-alloc-tags-01-sortingfrom
zero-alloc-tags-02-serialize

Conversation

@th0114nd

@th0114nd th0114nd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

SerializeTags previously hand-unrolled its own compare-and-swap sort
for 1-4 tags, duplicating the tuned sorting network already
maintained in TagSet.Sort(), and its >4 tag branch always
heap-allocated the pairs TagSet before also heap-allocating the
output buffer (2 allocations for any tag count above 4).

Adds gatherValidTags/numValidTags, shared helpers that gather tags
into a caller-provided TagSet (typically backed by a small stack
array for tag counts up to 16, falling back to a single exact-size
heap allocation otherwise) and sort via the real TagSet.Sort().
SerializeTags now gathers this way and calls TagSet.Serialize,
reducing to exactly one allocation for any tag count that fits the
stack tier, instead of two, while removing the duplicated sorting
logic.

These helpers are also intended to back a hash-based lookup path in
a follow-up change, so both can share the same gather/sort machinery
from the start.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com


Stack created with GitHub Stacks CLIGive Feedback 💬

SerializeTags previously hand-unrolled its own compare-and-swap sort
for 1-4 tags, duplicating the tuned sorting network already
maintained in TagSet.Sort(), and its >4 tag branch always
heap-allocated the pairs TagSet before also heap-allocating the
output buffer (2 allocations for any tag count above 4).

Adds gatherValidTags/numValidTags, shared helpers that gather tags
into a caller-provided TagSet (typically backed by a small stack
array for tag counts up to 16, falling back to a single exact-size
heap allocation otherwise) and sort via the real TagSet.Sort().
SerializeTags now gathers this way and calls TagSet.Serialize,
reducing to exactly one allocation for any tag count that fits the
stack tier, instead of two, while removing the duplicated sorting
logic.

These helpers are also intended to back a hash-based lookup path in
a follow-up change, so both can share the same gather/sort machinery
from the start.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant