internal/tags: route SerializeTags through TagSet - #186
Draft
th0114nd wants to merge 1 commit into
Draft
Conversation
SerializeTags previously hand-unrolled its own compare-and-swap sort for 1-4 tags, duplicating the tuned sorting network already maintained in TagSet.Sort(), and its >4 tag branch always heap-allocated the pairs TagSet before also heap-allocating the output buffer (2 allocations for any tag count above 4). Adds gatherValidTags/numValidTags, shared helpers that gather tags into a caller-provided TagSet (typically backed by a small stack array for tag counts up to 16, falling back to a single exact-size heap allocation otherwise) and sort via the real TagSet.Sort(). SerializeTags now gathers this way and calls TagSet.Serialize, reducing to exactly one allocation for any tag count that fits the stack tier, instead of two, while removing the duplicated sorting logic. These helpers are also intended to back a hash-based lookup path in a follow-up change, so both can share the same gather/sort machinery from the start. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializeTags previously hand-unrolled its own compare-and-swap sort
for 1-4 tags, duplicating the tuned sorting network already
maintained in TagSet.Sort(), and its >4 tag branch always
heap-allocated the pairs TagSet before also heap-allocating the
output buffer (2 allocations for any tag count above 4).
Adds gatherValidTags/numValidTags, shared helpers that gather tags
into a caller-provided TagSet (typically backed by a small stack
array for tag counts up to 16, falling back to a single exact-size
heap allocation otherwise) and sort via the real TagSet.Sort().
SerializeTags now gathers this way and calls TagSet.Serialize,
reducing to exactly one allocation for any tag count that fits the
stack tier, instead of two, while removing the duplicated sorting
logic.
These helpers are also intended to back a hash-based lookup path in
a follow-up change, so both can share the same gather/sort machinery
from the start.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬