internal/tags: unify SerializeTags/HashTags gathering via TagSet - #184
Closed
th0114nd wants to merge 1 commit into
Closed
internal/tags: unify SerializeTags/HashTags gathering via TagSet#184th0114nd wants to merge 1 commit into
th0114nd wants to merge 1 commit into
Conversation
SerializeTags previously hand-unrolled its own compare-and-swap sort for 1-4 tags, duplicating the tuned sorting network already maintained in TagSet.Sort(), and its >4 tag branch always heap-allocated the pairs TagSet before also heap-allocating the output buffer (2 allocations for any tag count above 4). Both SerializeTags and HashTags now share gatherValidTags/ numValidTags: gather into a small stack array (or a single exact-size heap allocation past 16 tags) and sort via the real TagSet.Sort(), then call TagSet.Serialize/TagSet.Hash. This removes the duplicated sorting logic and reduces SerializeTags to exactly one allocation for any tag count that fits the stack tier, instead of two. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by reordered stack — see the new PR chain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializeTags previously hand-unrolled its own compare-and-swap sort
for 1-4 tags, duplicating the tuned sorting network already
maintained in TagSet.Sort(), and its >4 tag branch always
heap-allocated the pairs TagSet before also heap-allocating the
output buffer (2 allocations for any tag count above 4).
Both SerializeTags and HashTags now share gatherValidTags/
numValidTags: gather into a small stack array (or a single
exact-size heap allocation past 16 tags) and sort via the real
TagSet.Sort(), then call TagSet.Serialize/TagSet.Hash. This removes
the duplicated sorting logic and reduces SerializeTags to exactly
one allocation for any tag count that fits the stack tier, instead
of two.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬